-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: fix the merging issue of labels after store reboot #6468
Conversation
Signed-off-by: JmPotato <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 2bf65db
|
In response to a cherrypick label: new pull request created to branch |
ref tikv#5510, close tikv#6467 Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
…6470) ref #5510, close #6467, ref #6468 #5510 introduced a bug that would cause the store labels to be overwritten wrongly after the store reboot. This PR fixed this issue. Signed-off-by: JmPotato <[email protected]> Co-authored-by: JmPotato <[email protected]>
…6469) ref #5510, close #6467, ref #6468 #5510 introduced a bug that would cause the store labels to be overwritten wrongly after the store reboot. This PR fixed this issue. Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: JmPotato <[email protected]> Co-authored-by: JmPotato <[email protected]>
I am testing in version v6.5.3. 10.2.8.3 Pd-ctl modified tiup cluster display hwtest1 --labels 10.2.8.3 reload 10.2.8.3 After reloading, it was found that the host was restored to its pre-modified state, but the zone was configured. Is this as expected? |
What problem does this PR solve?
Issue Number: Close #6467.
What is changed and how does it work?
Check List
Tests
Release note