checker: fix unhealth region skip the rule check #6427

nolouch · 2023-05-10T03:50:25Z

What problem does this PR solve?

Issue Number: Close #6426

What is changed and how does it work?

allow the `schedule=deny` label can do rule constraints check

Check List

Tests

Unit test
Integration test

Release note

None.

Signed-off-by: nolouch <[email protected]>

ti-chi-bot · 2023-05-10T03:50:27Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

bufferflies
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2023-05-10T04:06:40Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (490c7a8) 75.11% compared to head (9cccdda) 75.11%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6427   +/-   ##
=======================================
  Coverage   75.11%   75.11%           
=======================================
  Files         409      409           
  Lines       41484    41488    +4     
=======================================
+ Hits        31160    31165    +5     
- Misses       7630     7634    +4     
+ Partials     2694     2689    -5

Flag	Coverage Δ
unittests	`75.11% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/schedule/operator_controller.go	`86.51% <ø> (-1.29%)`	⬇️
server/cluster/cluster.go	`81.74% <ø> (+0.15%)`	⬆️
pkg/schedule/checker/checker_controller.go	`80.00% <100.00%> (+2.47%)`	⬆️
pkg/schedule/metrics.go	`100.00% <100.00%> (ø)`
server/cluster/coordinator.go	`72.81% <100.00%> (+0.41%)`	⬆️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

server/cluster/cluster.go

rleungx · 2023-05-10T05:31:39Z

pkg/schedule/operator_controller.go

@@ -424,14 +423,6 @@ func (oc *OperatorController) checkAddOperator(isPromoting bool, ops ...*operato
 		if op.SchedulerKind() == operator.OpAdmin || op.IsLeaveJointStateOperator() {
 			continue
 		}
-		if cl, ok := oc.cluster.(interface{ GetRegionLabeler() *labeler.RegionLabeler }); ok {


It seems we need to use the way of pausing schedulers to prevent the range from being scheduled.

I add the tests, prevent it in coordinator.

Signed-off-by: nolouch <[email protected]>

pkg/schedule/checker/checker_controller.go

Signed-off-by: nolouch <[email protected]>

server/cluster/coordinator.go

bufferflies

rest LGTM

Signed-off-by: nolouch <[email protected]>

nolouch · 2023-05-10T11:29:08Z

/merge

ti-chi-bot · 2023-05-10T11:29:09Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-05-10T11:29:10Z

This pull request has been accepted and is ready to merge.

Commit hash: 1abc0e5

ti-chi-bot · 2023-05-10T14:40:23Z

In response to a cherrypick label: new pull request created to branch release-6.5: #6430.

close tikv#6426 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2023-05-10T14:41:02Z

In response to a cherrypick label: new pull request created to branch release-7.1: #6431.

close #6426, ref #6427 allow the `schedule=deny` label can do rule constraints check Signed-off-by: nolouch <[email protected]> Co-authored-by: nolouch <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

close tikv#6426 allow the `schedule=deny` label can do rule constraints check Signed-off-by: nolouch <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

close #6426, ref #6427 allow the `schedule=deny` label can do rule constraints check Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: nolouch <[email protected]> Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: nolouch <[email protected]> Co-authored-by: Ryan Leung <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

ti-chi-bot · 2024-02-18T08:50:37Z

In response to a cherrypick label: new pull request created to branch release-6.1: #7822.

close tikv#6426 Signed-off-by: ti-chi-bot <[email protected]>

close #6426 allow the `schedule=deny` label can do rule constraints check Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: nolouch <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: nolouch <[email protected]>

…kv#6427 Signed-off-by: Shirly <[email protected]>

checker: fix unhealth region skip the rule check

89b8e1a

Signed-off-by: nolouch <[email protected]>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels May 10, 2023

ti-chi-bot bot requested review from lhy1024 and rleungx May 10, 2023 03:50

ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels May 10, 2023

rleungx reviewed May 10, 2023

View reviewed changes

address

be88112

Signed-off-by: nolouch <[email protected]>

rleungx approved these changes May 10, 2023

View reviewed changes

ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2023

adjust metrics

0b57560

Signed-off-by: nolouch <[email protected]>

nolouch requested review from bufferflies and removed request for lhy1024 May 10, 2023 10:12

comments

98c9e81

Signed-off-by: nolouch <[email protected]>

bufferflies reviewed May 10, 2023

View reviewed changes

pkg/schedule/checker/checker_controller.go Show resolved Hide resolved

address comments

3ba6a7a

Signed-off-by: nolouch <[email protected]>

bufferflies reviewed May 10, 2023

View reviewed changes

server/cluster/coordinator.go Outdated Show resolved Hide resolved

bufferflies approved these changes May 10, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2023

address comments

1abc0e5

Signed-off-by: nolouch <[email protected]>

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2023

Merge branch 'master' into fix-unhealth

9cccdda

ti-chi-bot bot merged commit 2e12b96 into tikv:master May 10, 2023

ti-chi-bot mentioned this pull request May 10, 2023

checker: fix unhealth region skip the rule check (#6427) #6430

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request May 10, 2023

This is an automated cherry-pick of tikv#6427

d60bf1d

close tikv#6426 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request May 10, 2023

checker: fix unhealth region skip the rule check (#6427) #6431

Merged

nolouch deleted the fix-unhealth branch May 10, 2023 14:46

rleungx added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Feb 18, 2024

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 18, 2024

This is an automated cherry-pick of tikv#6427

0423dfc

close tikv#6426 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Feb 18, 2024

checker: fix unhealth region skip the rule check (#6427) #7822

Merged

AndreMouche added a commit to AndreMouche/pd that referenced this pull request Oct 12, 2024

operator/operator_controller: remove redundant logic introduced by ti…

8d24334

…kv#6427 Signed-off-by: Shirly <[email protected]>

AndreMouche mentioned this pull request Oct 12, 2024

operatror_controller:remove redundant logic introduced by #6427 #8696

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

checker: fix unhealth region skip the rule check #6427

checker: fix unhealth region skip the rule check #6427

nolouch commented May 10, 2023 •

edited

Loading

ti-chi-bot bot commented May 10, 2023 •

edited

Loading

codecov bot commented May 10, 2023 •

edited

Loading

rleungx May 10, 2023

nolouch May 10, 2023

bufferflies left a comment

nolouch commented May 10, 2023

ti-chi-bot bot commented May 10, 2023

ti-chi-bot bot commented May 10, 2023

ti-chi-bot commented May 10, 2023

ti-chi-bot commented May 10, 2023

ti-chi-bot commented Feb 18, 2024

checker: fix unhealth region skip the rule check #6427

checker: fix unhealth region skip the rule check #6427

Conversation

nolouch commented May 10, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented May 10, 2023 • edited Loading

codecov bot commented May 10, 2023 • edited Loading

Codecov Report

rleungx May 10, 2023

Choose a reason for hiding this comment

nolouch May 10, 2023

Choose a reason for hiding this comment

bufferflies left a comment

Choose a reason for hiding this comment

nolouch commented May 10, 2023

ti-chi-bot bot commented May 10, 2023

ti-chi-bot bot commented May 10, 2023

ti-chi-bot commented May 10, 2023

ti-chi-bot commented May 10, 2023

ti-chi-bot commented Feb 18, 2024

nolouch commented May 10, 2023 •

edited

Loading

ti-chi-bot bot commented May 10, 2023 •

edited

Loading

codecov bot commented May 10, 2023 •

edited

Loading