-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix deletion of region stats metrics after resign #6367
*: fix deletion of region stats metrics after resign #6367
Conversation
Signed-off-by: iosmanthus <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@AmoebaProtozoa: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6367 +/- ##
==========================================
+ Coverage 75.08% 75.11% +0.03%
==========================================
Files 408 408
Lines 40598 40611 +13
==========================================
+ Hits 30481 30505 +24
+ Misses 7476 7467 -9
+ Partials 2641 2639 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 27 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
/check-issue-triage-complete |
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1b87793
|
In response to a cherrypick label: new pull request created to branch |
* fix misused Reset Signed-off-by: iosmanthus <[email protected]> * fix the flaky test Signed-off-by: Ryan Leung <[email protected]> --------- Signed-off-by: iosmanthus <[email protected]> Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: iosmanthus <[email protected]> Co-authored-by: Ryan Leung <[email protected]>
What problem does this PR solve?
Issue Number: Close #6366
What is changed and how does it work?
https://github.com/prometheus/client_golang/blob/d7896d4bd082b17e525c29055d79cc29484aa9cb/prometheus/vec.go#L125 doesn't reset the gauge in this metrics vec, instead, it deletes them all.
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note