-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cgroup: refine the handling of error 'no cpu controller detected' #5999
Conversation
Signed-off-by: Sen Han <[email protected]>
Signed-off-by: Sen Han <[email protected]>
Signed-off-by: Sen Han <[email protected]>
Signed-off-by: Sen Han <[email protected]>
Signed-off-by: Sen Han <[email protected]>
Signed-off-by: Sen Han <[email protected]>
Signed-off-by: Sen Han <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @hnes. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @nolouch |
Codecov ReportBase: 75.09% // Head: 75.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5999 +/- ##
==========================================
+ Coverage 75.09% 75.32% +0.23%
==========================================
Files 362 362
Lines 36316 36316
==========================================
+ Hits 27270 27356 +86
+ Misses 6668 6612 -56
+ Partials 2378 2348 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Sen Han <[email protected]>
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 00b04b8
|
What problem does this PR solve?
Issue Number: Ref #5953
What is changed and how does it work?
Ignore error 'no cpu controller detected' on old kernel but still panic on new kernel. (Thanks a lot for the advice from @nolouch)
Remove TestGetCgroupCPU from the flaky test list.
Reference:
pingcap/tidb#41347
pingcap/tidb#41475
Check List
Tests
Release note