Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix witness count id and datasource #5894

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

ethercflow
Copy link
Member

@ethercflow ethercflow commented Feb 2, 2023

ref #5568

Signed-off-by: Wenbo Zhang [email protected]

What problem does this PR solve?

Issue Number: ref #5568

What is changed and how does it work?

Fix the duplicate id and modify the data source as a variable

Check List

Tests

  • None

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 2, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 75.59% // Head: 75.73% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (3ced238) compared to base (6ca9a33).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5894      +/-   ##
==========================================
+ Coverage   75.59%   75.73%   +0.13%     
==========================================
  Files         342      342              
  Lines       34858    34858              
==========================================
+ Hits        26352    26398      +46     
+ Misses       6247     6220      -27     
+ Partials     2259     2240      -19     
Flag Coverage Δ
unittests 75.73% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/schedulers/random_merge.go 62.50% <0.00%> (-3.13%) ⬇️
pkg/election/leadership.go 77.31% <0.00%> (-3.10%) ⬇️
server/tso/local_allocator.go 68.91% <0.00%> (-2.71%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
pkg/election/lease.go 84.05% <0.00%> (-1.45%) ⬇️
server/storage/hot_region_storage.go 78.14% <0.00%> (-1.10%) ⬇️
server/cluster/coordinator.go 71.59% <0.00%> (-0.76%) ⬇️
server/schedule/operator/step.go 76.76% <0.00%> (-0.69%) ⬇️
server/cluster/unsafe_recovery_controller.go 78.70% <0.00%> (-0.35%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2023
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 2, 2023
@Connor1996
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3ced238

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2023
@ti-chi-bot ti-chi-bot merged commit 8830739 into tikv:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants