Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: use public stores cache in placement rules cache #5877

Merged
merged 6 commits into from
Jan 19, 2023

Conversation

HunDunDM
Copy link
Member

Signed-off-by: HunDunDM [email protected]

What problem does this PR solve?

Issue Number: Ref #5864

There is labels map[string]string in storeCache. When the store has longer or more labels, each region cache will use a lot of memory.

What is changed and how does it work?

part of #5860

use public stores cache in placement rules cache.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 19, 2023
@ti-chi-bot ti-chi-bot requested a review from Yisaer January 19, 2023 09:56
Signed-off-by: HunDunDM <[email protected]>
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 75.51% // Head: 75.44% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (3abe2a1) compared to base (6e35a4d).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 3abe2a1 differs from pull request most recent head 82ced3c. Consider uploading reports for the commit 82ced3c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5877      +/-   ##
==========================================
- Coverage   75.51%   75.44%   -0.07%     
==========================================
  Files         341      341              
  Lines       34413    34409       -4     
==========================================
- Hits        25986    25959      -27     
- Misses       6191     6203      +12     
- Partials     2236     2247      +11     
Flag Coverage Δ
unittests 75.44% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/placement/region_rule_cache.go 88.76% <100.00%> (+0.66%) ⬆️
pkg/utils/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
pkg/storage/endpoint/meta.go 63.63% <0.00%> (-4.55%) ⬇️
server/region_syncer/server.go 82.96% <0.00%> (-4.40%) ⬇️
pkg/id/id.go 86.44% <0.00%> (-3.39%) ⬇️
server/tso/tso.go 70.78% <0.00%> (-2.25%) ⬇️
server/tso/allocator_manager.go 60.64% <0.00%> (-1.94%) ⬇️
pkg/encryption/key_manager.go 70.11% <0.00%> (-1.60%) ⬇️
server/region_syncer/client.go 85.07% <0.00%> (-1.50%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: HunDunDM <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 19, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 19, 2023
@HunDunDM
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 37f8def

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 19, 2023
@ti-chi-bot ti-chi-bot merged commit 5c518d0 into tikv:master Jan 19, 2023
@HunDunDM HunDunDM deleted the rules-cache/public-stores-cache branch January 19, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants