-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource_manager: introduce the resource unit model and config #5862
Conversation
Signed-off-by: JmPotato <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportBase: 75.62% // Head: 75.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5862 +/- ##
==========================================
- Coverage 75.62% 75.43% -0.20%
==========================================
Files 337 337
Lines 34129 34129
==========================================
- Hits 25810 25745 -65
- Misses 6111 6158 +47
- Partials 2208 2226 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Signed-off-by: JmPotato <[email protected]>
const ( | ||
defaultReadBaseCost = 1 | ||
defaultReadCostPerByte = 1. / 1024 / 1024 | ||
defaultWriteBaseCost = 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it too high?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense. Let's keep it a smaller value first. We can adjust it after some tests.
Signed-off-by: JmPotato <[email protected]>
71c96f9
to
527b6b8
Compare
Signed-off-by: JmPotato <[email protected]>
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: e48b2fc
|
@JmPotato: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: JmPotato [email protected]
What problem does this PR solve?
Issue Number: ref #5851.
What is changed and how does it work?
Check List
Tests
Related changes
Release note