operator: When replacing-down-peer, it should not stop at the step of leave-joint-state (#5789)

[ti-chi-bot]

This is an automated cherry-pick of #5789

Signed-off-by: HunDunDM [email protected]

What problem does this PR solve?

Issue Number: Close #5788

What is changed and how does it work?

Rolled back some code from #5568 and added unittest.

Check List

Tests

• Unit test

Code changes

Side effects

Related changes

• Need to cherry-pick to the release branch

Release note

Fixed an issue that `replace-down-peer` could be too slow.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Base: 75.54% // Head: 75.49% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (11b84a5) compared to base (d1c0d84).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 11b84a5 differs from pull request most recent head 82c3409. Consider uploading reports for the commit 82c3409 to get more accurate results

Additional details and impacted files

@@               Coverage Diff               @@
##           release-6.5    #5795      +/-   ##
===============================================
- Coverage        75.54%   75.49%   -0.05%     
===============================================
  Files              330      330              
  Lines            32951    32937      -14     
===============================================
- Hits             24894    24867      -27     
- Misses            5907     5913       +6     
- Partials          2150     2157       +7     

Flag	Coverage Δ
unittests	75.49% <100.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedule/operator/step.go	73.09% <100.00%> (ø)
server/api/diagnostic.go	76.92% <0.00%> (-23.08%)	⬇️
server/id/id.go	83.05% <0.00%> (-6.78%)	⬇️
pkg/dashboard/adapter/manager.go	73.56% <0.00%> (-5.75%)	⬇️
server/tso/tso.go	69.10% <0.00%> (-5.62%)	⬇️
server/cluster/diagnostic_manager.go	72.04% <0.00%> (-4.31%)	⬇️
server/schedule/checker/rule_checker.go	80.15% <0.00%> (-1.90%)	⬇️
server/schedule/hbstream/heartbeat_streams.go	71.71% <0.00%> (-1.02%)	⬇️
server/tso/allocator_manager.go	62.90% <0.00%> (-0.81%)	⬇️
server/statistics/hot_peer_cache.go	96.13% <0.00%> (-0.78%)	⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[nolouch]

/merge

[ti-chi-bot]

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 11b84a5

[ti-chi-bot]

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.