-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: update hot region scheduler default config for v2 #5590
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-build-arm64 comment=true |
download pd binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/pd/557d91d2fe5274fa1f51e32fcee57a1271c5083b/centos7/pd-linux-arm64.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
ptal @HunDunDM
I will fix test |
Signed-off-by: lhy1024 <[email protected]>
Codecov ReportBase: 75.61% // Head: 75.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5590 +/- ##
==========================================
- Coverage 75.61% 75.54% -0.08%
==========================================
Files 326 326
Lines 32370 32370
==========================================
- Hits 24478 24455 -23
- Misses 5777 5799 +22
- Partials 2115 2116 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 8306837
|
@lhy1024: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 9572269
|
Signed-off-by: lhy1024 [email protected]
What problem does this PR solve?
Issue Number: Ref #4949
What is changed and how does it work?
Check List
Tests
Side effects
Release note