Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: update hot region scheduler default config for v2 #5590

Merged
merged 2 commits into from
Oct 22, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Oct 12, 2022

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: Ref #4949

What is changed and how does it work?

  • For clusters upgraded from [5.2, 6.3] versions, this configuration will remain unchanged

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Possible performance regression

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 12, 2022
@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 13, 2022

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Oct 13, 2022

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
ptal @HunDunDM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 17, 2022
@nolouch nolouch requested review from HunDunDM and removed request for disksing and rleungx October 18, 2022 06:07
@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 18, 2022

I will fix test

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 75.61% // Head: 75.54% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (8306837) compared to base (8ed1660).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8306837 differs from pull request most recent head 9572269. Consider uploading reports for the commit 9572269 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5590      +/-   ##
==========================================
- Coverage   75.61%   75.54%   -0.08%     
==========================================
  Files         326      326              
  Lines       32370    32370              
==========================================
- Hits        24478    24455      -23     
- Misses       5777     5799      +22     
- Partials     2115     2116       +1     
Flag Coverage Δ
unittests 75.54% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region_config.go 92.54% <100.00%> (ø)
pkg/dashboard/keyvisual/input/core.go 0.00% <0.00%> (-33.34%) ⬇️
server/schedulers/shuffle_hot_region.go 56.00% <0.00%> (-10.00%) ⬇️
server/tso/allocator_manager.go 61.20% <0.00%> (-3.25%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
server/member/member.go 63.68% <0.00%> (-2.11%) ⬇️
server/encryptionkm/key_manager.go 70.11% <0.00%> (-1.60%) ⬇️
pkg/btree/btree.go 86.26% <0.00%> (-0.97%) ⬇️
server/statistics/hot_peer_cache.go 96.89% <0.00%> (-0.78%) ⬇️
server/schedulers/hot_region.go 85.00% <0.00%> (-0.49%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 21, 2022
@nolouch
Copy link
Contributor

nolouch commented Oct 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8306837

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 22, 2022
@ti-chi-bot
Copy link
Member

@lhy1024: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Oct 22, 2022
@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9572269

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 22, 2022
@ti-chi-bot ti-chi-bot merged commit ec8ff1a into tikv:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants