-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: unify the length of Loads
in hot statistics to 3
#5501
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportBase: 75.56% // Head: 75.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5501 +/- ##
==========================================
+ Coverage 75.56% 75.65% +0.09%
==========================================
Files 321 321
Lines 31866 31855 -11
==========================================
+ Hits 24078 24101 +23
+ Misses 5712 5679 -33
+ Partials 2076 2075 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
statistics.RegionWriteBytes: 1 * units.KiB, | ||
statistics.RegionWriteKeys: 32, | ||
statistics.RegionWriteQuery: 32, | ||
var minHotThresholds [statistics.RegionStatCount]uint64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be the same? cc @bufferflies
statistics.RegionWriteQuery: 32, | ||
var minHotThresholds [statistics.RegionStatCount]uint64 | ||
|
||
func init() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to make a copy in the init function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Their values are the same.
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 08f4b69
|
@HunDunDM: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close #5021, ref #5501 Signed-off-by: HunDunDM <[email protected]>
What problem does this PR solve?
Issue Number: Close #5500
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note