Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: Remove redundant judgment in hot-region #5369

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

CabinfeverB
Copy link
Member

Signed-off-by: Cabinfever_B [email protected]

What problem does this PR solve?

Issue Number: Close #5368

What is changed and how does it work?

Remove redundant judgment in hot-region

Check List

Release note

None.

Signed-off-by: Cabinfever_B <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 28, 2022
@ti-chi-bot ti-chi-bot requested review from HunDunDM and Yisaer July 28, 2022 08:53
@CabinfeverB CabinfeverB requested review from lhy1024 and removed request for Yisaer July 28, 2022 08:55
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #5369 (2c24720) into master (e359ed3) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5369      +/-   ##
==========================================
+ Coverage   75.72%   75.79%   +0.06%     
==========================================
  Files         312      312              
  Lines       31048    31041       -7     
==========================================
+ Hits        23512    23527      +15     
+ Misses       5535     5512      -23     
- Partials     2001     2002       +1     
Flag Coverage Δ
unittests 75.79% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 84.68% <ø> (+0.50%) ⬆️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
pkg/metricutil/metricutil.go 82.75% <0.00%> (-10.35%) ⬇️
server/storage/endpoint/meta.go 61.36% <0.00%> (-4.55%) ⬇️
server/storage/storage.go 67.30% <0.00%> (-3.85%) ⬇️
server/region_syncer/client.go 85.07% <0.00%> (-2.99%) ⬇️
pkg/dashboard/adapter/manager.go 79.31% <0.00%> (-2.30%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
server/config/persist_options.go 92.33% <0.00%> (-1.75%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e359ed3...2c24720. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2022
@nolouch
Copy link
Contributor

nolouch commented Jul 28, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2c24720

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2022
@ti-chi-bot ti-chi-bot merged commit 3df67ab into tikv:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is some redundant judgment logic in hot-region
4 participants