statistics: show stores of peers in pd-ctl output

[lhy1024]

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: Ref #4949

What is changed and how does it work?

Check List

Tests

• Unit test

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• CabinfeverB
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #5330 (8b2c6c6) into master (3df67ab) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5330      +/-   ##
==========================================
- Coverage   75.64%   75.60%   -0.04%     
==========================================
  Files         312      312              
  Lines       31041    31045       +4     
==========================================
- Hits        23482    23473       -9     
- Misses       5549     5572      +23     
+ Partials     2010     2000      -10     

Flag	Coverage Δ
unittests	75.60% <100.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/handler.go	52.03% <100.00%> (-0.94%)	⬇️
server/statistics/hot_peer.go	96.87% <100.00%> (+0.26%)	⬆️
server/statistics/hot_peer_cache.go	96.92% <100.00%> (+0.02%)	⬆️
server/statistics/store_load.go	95.90% <100.00%> (+0.10%)	⬆️
server/schedulers/shuffle_hot_region.go	55.55% <0.00%> (-10.11%)	⬇️
server/tso/allocator_manager.go	58.04% <0.00%> (-4.98%)	⬇️
server/election/leadership.go	77.31% <0.00%> (-3.10%)	⬇️
server/tso/tso.go	67.79% <0.00%> (-2.83%)	⬇️
tools/pd-ctl/pdctl/command/operator.go	66.66% <0.00%> (-1.15%)	⬇️
server/schedulers/evict_leader.go	78.57% <0.00%> (-0.90%)	⬇️
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df67ab...8b2c6c6. Read the comment docs.

[nolouch]

lgtm

[nolouch]

BTW, will it affect the HISTORY_HOT_REGIONS?

[nolouch]

Ping @lhy1024

[lhy1024]

HISTORY_HOT_REGIONS

BTW, will it affect the HISTORY_HOT_REGIONS?

This struct does not affect the results of HistoryHotRegions, which has a separate struct and uses some functions to solve, such as

pd/server/handler.go

Line 1000 in 7187a7a

func (h *Handler) PackHistoryHotReadRegions() ([]storage.HistoryHotRegion, error) {

,

pd/server/handler.go

Line 1010 in 7187a7a

func (h *Handler) PackHistoryHotWriteRegions() ([]storage.HistoryHotRegion, error) {

, but it is possible to optimize the process

[nolouch]

PTAL @HunDunDM

[lhy1024]

/merge

[ti-chi-bot]

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 1dfe189

[ti-chi-bot]

@lhy1024: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.