Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: make hot split region more readable #5306

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jul 14, 2022

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None

@lhy1024 lhy1024 added component/metrics Metrics. require-LGT1 Indicates that the PR requires an LGTM. labels Jul 14, 2022
@lhy1024 lhy1024 requested a review from bufferflies July 14, 2022 04:54
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 14, 2022
@lhy1024 lhy1024 marked this pull request as ready for review July 14, 2022 04:54
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2022
@lhy1024 lhy1024 added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #5306 (c98171f) into master (8a96807) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5306      +/-   ##
==========================================
+ Coverage   75.75%   75.77%   +0.01%     
==========================================
  Files         311      311              
  Lines       30830    30830              
==========================================
+ Hits        23354    23360       +6     
+ Misses       5480     5473       -7     
- Partials     1996     1997       +1     
Flag Coverage Δ
unittests 75.77% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 83.52% <0.00%> (-0.29%) ⬇️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/storage/endpoint/rule.go 83.33% <0.00%> (-11.12%) ⬇️
pkg/dashboard/adapter/manager.go 74.71% <0.00%> (-4.60%) ⬇️
pkg/etcdutil/etcdutil.go 84.88% <0.00%> (-3.49%) ⬇️
server/election/lease.go 84.05% <0.00%> (-2.90%) ⬇️
server/tso/tso.go 71.75% <0.00%> (-1.70%) ⬇️
server/member/member.go 64.21% <0.00%> (-1.58%) ⬇️
server/region_syncer/client.go 86.56% <0.00%> (-1.50%) ⬇️
server/schedule/placement/rule_manager.go 84.13% <0.00%> (-1.14%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a96807...c98171f. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2022
@bufferflies bufferflies removed the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jul 14, 2022
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 14, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c98171f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2022
@ti-chi-bot ti-chi-bot merged commit 34a4cce into tikv:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics Metrics. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants