Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: some misc modify for testify #5239

Merged
merged 3 commits into from
Jun 28, 2022
Merged

*: some misc modify for testify #5239

merged 3 commits into from
Jun 28, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jun 28, 2022

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: Ref #4813.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024 lhy1024 requested review from JmPotato and rleungx June 28, 2022 07:38
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 28, 2022
Signed-off-by: lhy1024 <[email protected]>
server/cluster/coordinator_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2022
Signed-off-by: lhy1024 <[email protected]>
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #5239 (1c10ee8) into master (6db8815) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5239      +/-   ##
==========================================
+ Coverage   75.46%   75.56%   +0.10%     
==========================================
  Files         310      310              
  Lines       30708    30695      -13     
==========================================
+ Hits        23174    23195      +21     
+ Misses       5529     5497      -32     
+ Partials     2005     2003       -2     
Flag Coverage Δ
unittests 75.56% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/testutil/operator_check.go 89.00% <ø> (+10.23%) ⬆️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
pkg/etcdutil/etcdutil.go 84.88% <0.00%> (-3.49%) ⬇️
server/election/leadership.go 77.31% <0.00%> (-3.10%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
server/region_syncer/client.go 85.82% <0.00%> (-2.24%) ⬇️
client/base_client.go 79.38% <0.00%> (-2.07%) ⬇️
server/api/region.go 67.38% <0.00%> (-1.92%) ⬇️
server/schedule/operator_controller.go 85.77% <0.00%> (-0.81%) ⬇️
server/cluster/cluster.go 83.54% <0.00%> (-0.37%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db8815...1c10ee8. Read the comment docs.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 28, 2022
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 28, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1c10ee8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2022
@JmPotato
Copy link
Member

/rebuild

@ti-chi-bot ti-chi-bot merged commit baa4357 into tikv:master Jun 28, 2022
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants