-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove duplicated functions #5224
Conversation
Signed-off-by: Ryan Leung <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #5224 +/- ##
==========================================
- Coverage 75.67% 75.48% -0.19%
==========================================
Files 310 310
Lines 30674 30674
==========================================
- Hits 23212 23155 -57
- Misses 5472 5514 +42
- Partials 1990 2005 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 565cf6a
|
ref tikv#4813 Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung [email protected]
What problem does this PR solve?
Issue Number: Ref #4813.
What is changed and how does it work?
This PR removes some unnecessarily duplicated functions.
Check List
Tests
Release note