Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove duplicated functions #5224

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 23, 2022

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Ref #4813.

What is changed and how does it work?

This PR removes some unnecessarily duplicated functions.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 23, 2022
@ti-chi-bot ti-chi-bot requested review from JmPotato and nolouch June 23, 2022 11:34
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #5224 (565cf6a) into master (e4ca2e6) will decrease coverage by 0.18%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #5224      +/-   ##
==========================================
- Coverage   75.67%   75.48%   -0.19%     
==========================================
  Files         310      310              
  Lines       30674    30674              
==========================================
- Hits        23212    23155      -57     
- Misses       5472     5514      +42     
- Partials     1990     2005      +15     
Flag Coverage Δ
unittests 75.48% <75.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/pdctl/helper.go 100.00% <ø> (+1.78%) ⬆️
pkg/assertutil/assertutil.go 88.88% <75.00%> (-11.12%) ⬇️
server/tso/local_allocator.go 68.91% <0.00%> (-9.46%) ⬇️
server/storage/kv/etcd_kv.go 79.71% <0.00%> (-5.80%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/storage/endpoint/meta.go 64.04% <0.00%> (-4.50%) ⬇️
server/region_syncer/server.go 83.15% <0.00%> (-4.35%) ⬇️
server/tso/allocator_manager.go 62.39% <0.00%> (-3.17%) ⬇️
client/base_client.go 79.38% <0.00%> (-2.58%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ca2e6...565cf6a. Read the comment docs.

@nolouch
Copy link
Contributor

nolouch commented Jun 23, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 565cf6a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2022
@ti-chi-bot ti-chi-bot merged commit 1be84d6 into tikv:master Jun 23, 2022
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants