Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace Id with ID #5209

Merged
merged 2 commits into from
Jun 22, 2022
Merged

*: replace Id with ID #5209

merged 2 commits into from
Jun 22, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jun 21, 2022

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024 lhy1024 added the type/refactor The issue belongs to a refactor work. label Jun 21, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 21, 2022
@ti-chi-bot ti-chi-bot requested review from disksing and HunDunDM June 21, 2022 17:26
@lhy1024 lhy1024 changed the title *: replace Id with Ids *: replace Id with ID Jun 21, 2022
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2022
Signed-off-by: lhy1024 <[email protected]>
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #5209 (b52960a) into master (b100049) will increase coverage by 0.15%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #5209      +/-   ##
==========================================
+ Coverage   75.65%   75.81%   +0.15%     
==========================================
  Files         310      310              
  Lines       30675    30675              
==========================================
+ Hits        23208    23256      +48     
+ Misses       5463     5432      -31     
+ Partials     2004     1987      -17     
Flag Coverage Δ
unittests 75.81% <66.66%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/core/basic_cluster.go 91.28% <ø> (ø)
server/core/region.go 91.27% <ø> (ø)
server/core/region_option.go 83.17% <0.00%> (ø)
server/schedule/test_util.go 71.42% <ø> (ø)
server/schedulers/grant_hot_region.go 58.97% <0.00%> (ø)
server/schedule/checker/merge_checker.go 69.69% <100.00%> (ø)
server/schedule/checker/replica_strategy.go 88.63% <100.00%> (ø)
server/schedulers/balance_region.go 89.34% <100.00%> (ø)
server/schedulers/hot_region.go 83.52% <100.00%> (-0.29%) ⬇️
server/schedulers/shuffle_hot_region.go 55.55% <100.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b100049...b52960a. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2022
@rleungx
Copy link
Member

rleungx commented Jun 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b52960a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@ti-chi-bot ti-chi-bot merged commit ff82285 into tikv:master Jun 22, 2022
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/refactor The issue belongs to a refactor work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants