Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: migrate test framework to testify #5193

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 21, 2022

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Ref #4813.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 21, 2022
@ti-chi-bot ti-chi-bot requested review from disksing and nolouch June 21, 2022 03:08
@rleungx rleungx mentioned this pull request Jun 21, 2022
85 tasks
@rleungx rleungx requested review from JmPotato and removed request for disksing June 21, 2022 03:25
@rleungx rleungx marked this pull request as ready for review June 21, 2022 03:25
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2022
@@ -22,20 +22,14 @@ type Checker struct {
}

// NewChecker creates Checker with FailNow function.
func NewChecker(failNow func()) *Checker {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this arg?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we remove all pingcap/check dependencies, we can change it back.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #5193 (11e9ba9) into master (ff82285) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head 11e9ba9 differs from pull request most recent head 4f62d72. Consider uploading reports for the commit 4f62d72 to get more accurate results

@@            Coverage Diff             @@
##           master    #5193      +/-   ##
==========================================
- Coverage   75.79%   75.58%   -0.21%     
==========================================
  Files         310      310              
  Lines       30675    30673       -2     
==========================================
- Hits        23249    23184      -65     
- Misses       5429     5478      +49     
- Partials     1997     2011      +14     
Flag Coverage Δ
unittests 75.58% <100.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/assertutil/assertutil.go 100.00% <100.00%> (ø)
tests/pdctl/helper.go 98.21% <100.00%> (+1.78%) ⬆️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
...erver/config/service_middleware_persist_options.go 91.66% <0.00%> (-8.34%) ⬇️
server/storage/kv/etcd_kv.go 79.71% <0.00%> (-5.80%) ⬇️
server/region_syncer/client.go 81.34% <0.00%> (-4.48%) ⬇️
server/region_syncer/server.go 83.15% <0.00%> (-4.35%) ⬇️
server/member/member.go 63.68% <0.00%> (-3.69%) ⬇️
pkg/etcdutil/etcdutil.go 86.04% <0.00%> (-2.33%) ⬇️
client/base_client.go 79.89% <0.00%> (-2.07%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff28d7...4f62d72. Read the comment docs.

Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx requested review from JmPotato and lhy1024 June 21, 2022 09:32
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2022
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 11e9ba9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit da533eb into tikv:master Jun 22, 2022
@rleungx rleungx deleted the testify branch June 22, 2022 08:41
ti-chi-bot added a commit that referenced this pull request Jun 22, 2022
ref #4813, ref #5193

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
ti-chi-bot added a commit that referenced this pull request Jun 23, 2022
ref #4813, ref #5193

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
ref tikv#4813

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
ref tikv#4813, ref tikv#5193

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants