Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: testify some server tests #5186

Merged
merged 5 commits into from
Jun 22, 2022
Merged

tests: testify some server tests #5186

merged 5 commits into from
Jun 22, 2022

Conversation

JmPotato
Copy link
Member

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

Issue Number: ref #4813.

What is changed and how does it work?

Testify some server tests.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato requested a review from rleungx June 20, 2022 08:50
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 20, 2022
@JmPotato JmPotato requested a review from nolouch June 20, 2022 08:50
@JmPotato JmPotato mentioned this pull request Jun 20, 2022
Closed
85 tasks
rleungx
rleungx reviewed Jun 20, 2022
View reviewed changes
tests/server/join/join_test.go Outdated Show resolved Hide resolved
tests/server/join/join_test.go Outdated Show resolved Hide resolved
tests/server/join/join_test.go Outdated Show resolved Hide resolved
tests/server/region_syncer/region_syncer_test.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 21, 2022 •
edited
Loading

Codecov Report

Merging #5186 (2269670) into master (da533eb) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5186      +/-   ##
==========================================
+ Coverage   75.72%   75.74%   +0.01%     
==========================================
  Files         310      310              
  Lines       30673    30673              
==========================================
+ Hits        23228    23234       +6     
+ Misses       5446     5440       -6     
  Partials     1999     1999
Flag Coverage Δ
unittests 75.74% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/storage/endpoint/rule.go 83.33% <0.00%> (-11.12%) ⬇️
server/storage/kv/etcd_kv.go 72.46% <0.00%> (-7.25%) ⬇️
server/tso/tso.go 70.62% <0.00%> (-5.09%) ⬇️
server/election/leadership.go 77.31% <0.00%> (-3.10%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/schedule/placement/rule_manager.go 84.13% <0.00%> (-1.14%) ⬇️
server/cluster/cluster.go 83.27% <0.00%> (-0.46%) ⬇️
server/handler.go 52.58% <0.00%> (-0.39%) ⬇️
server/grpc_service.go 51.70% <0.00%> (-0.09%) ⬇️
server/server.go 74.53% <0.00%> (+0.26%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da533eb...2269670. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2022
JmPotato added 4 commits June 22, 2022 14:55
@JmPotato
Testify some server tests
cd49660 
Signed-off-by: JmPotato <[email protected]>
@JmPotato
Fix the test
324e6a0 
Signed-off-by: JmPotato <[email protected]>
@JmPotato
Address the comments
dc981d1 
Signed-off-by: JmPotato <[email protected]>
@JmPotato
Fix the test
47546b0 
Signed-off-by: JmPotato <[email protected]>
@JmPotato
Fix the test
2269670 
Signed-off-by: JmPotato <[email protected]>
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2269670

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@ti-chi-bot ti-chi-bot merged commit dcaa318 into tikv:master Jun 22, 2022
@JmPotato JmPotato deleted the testify_watch branch June 22, 2022 07:21
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
@JmPotato @CabinfeverB
tests: testify some server tests (tikv#5186)
c8ce97c 
ref tikv#4813

Testify some server tests.

Signed-off-by: JmPotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JmPotato @ti-chi-bot @lhy1024 @rleungx