Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: migrate test framework to testify #5111

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Conversation

LLThomas
Copy link
Contributor

@LLThomas LLThomas commented Jun 6, 2022

Signed-off-by: LLThomas [email protected]

What problem does this PR solve?

Issue Number: Ref #4813

What is changed and how does it work?

Just as the title says.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 6, 2022
@ti-chi-bot ti-chi-bot requested review from HunDunDM and rleungx June 6, 2022 11:52
@LLThomas LLThomas changed the title migrate test-infra to testify for server/storage/kv kv: testify the kv tests Jun 6, 2022
@LLThomas LLThomas changed the title kv: testify the kv tests kv: migrate test framework to testify Jun 6, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #5111 (0afbe92) into master (e244adb) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 0afbe92 differs from pull request most recent head 88472d2. Consider uploading reports for the commit 88472d2 to get more accurate results

@@            Coverage Diff             @@
##           master    #5111      +/-   ##
==========================================
- Coverage   75.58%   75.52%   -0.06%     
==========================================
  Files         308      308              
  Lines       30507    30475      -32     
==========================================
- Hits        23058    23017      -41     
- Misses       5455     5463       +8     
- Partials     1994     1995       +1     
Flag Coverage Δ
unittests 75.52% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cache/cache.go 53.57% <0.00%> (-10.72%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (-6.76%) ⬇️
server/region_syncer/client.go 79.85% <0.00%> (-5.98%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
server/tso/tso.go 70.05% <0.00%> (-2.26%) ⬇️
server/schedule/checker/rule_checker.go 78.17% <0.00%> (-1.73%) ⬇️
server/storage/hot_region_storage.go 78.14% <0.00%> (-1.10%) ⬇️
server/tso/global_allocator.go 61.49% <0.00%> (-1.07%) ⬇️
server/election/leadership.go 77.31% <0.00%> (-1.04%) ⬇️
server/grpc_service.go 52.43% <0.00%> (-0.89%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4133b9f...88472d2. Read the comment docs.

@nolouch nolouch requested a review from JmPotato June 7, 2022 02:34
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

server/storage/kv/kv_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 7, 2022
@JmPotato
Copy link
Member

JmPotato commented Jun 7, 2022

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 27c9a5b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2022
@ti-chi-bot
Copy link
Member

@LLThomas: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 36db3c7 into tikv:master Jun 7, 2022
@JmPotato JmPotato mentioned this pull request Jun 7, 2022
85 tasks
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants