Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix scheduling can not immediately start after transfer leader (#4875) #4969

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4875

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Close #4769.

What is changed and how does it work?

This PR uses the flag to distinguish if the region's heartbeat is new when transferring the PD leader.

Check List

Tests

  • Unit test

Release note

Fix the issue that scheduling cannot immediately start after PD leader transfers

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 17, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick. labels May 17, 2022
@ti-chi-bot ti-chi-bot requested review from lhy1024 and rleungx May 17, 2022 09:26
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 27, 2022
@rleungx rleungx force-pushed the cherry-pick-4875-to-release-5.3 branch 2 times, most recently from 51baf08 to 7dc3c44 Compare May 30, 2022 05:46
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx force-pushed the cherry-pick-4875-to-release-5.3 branch from 7dc3c44 to fd21675 Compare May 30, 2022 05:51
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #4969 (b52b8c5) into release-5.3 (2ebb589) will decrease coverage by 0.09%.
The diff coverage is 88.00%.

@@               Coverage Diff               @@
##           release-5.3    #4969      +/-   ##
===============================================
- Coverage        74.89%   74.80%   -0.10%     
===============================================
  Files              263      263              
  Lines            27341    27354      +13     
===============================================
- Hits             20478    20461      -17     
- Misses            5046     5069      +23     
- Partials          1817     1824       +7     
Flag Coverage Δ
unittests 74.80% <88.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/region_syncer/client.go 79.06% <50.00%> (-0.62%) ⬇️
server/cluster/cluster.go 82.67% <85.71%> (+0.21%) ⬆️
server/cluster/coordinator.go 74.78% <100.00%> (+0.52%) ⬆️
server/core/region.go 91.87% <100.00%> (+0.04%) ⬆️
server/core/region_option.go 82.85% <100.00%> (+0.33%) ⬆️
server/grpc_service.go 51.01% <100.00%> (+0.60%) ⬆️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/schedulers/shuffle_hot_region.go 55.55% <0.00%> (-10.11%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
pkg/etcdutil/etcdutil.go 82.35% <0.00%> (-5.89%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ebb589...b52b8c5. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 11, 2022
@nolouch
Copy link
Contributor

nolouch commented Jun 11, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: ca6635b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 88e39d7 into tikv:release-5.3 Jun 11, 2022
@purelind purelind added this to the v5.3.2 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants