-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checker: skip merge regions that are marked nomerge #4006
Conversation
Signed-off-by: disksing <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: bd9147a
|
Codecov Report
@@ Coverage Diff @@
## master #4006 +/- ##
==========================================
+ Coverage 74.50% 74.59% +0.08%
==========================================
Files 254 254
Lines 25822 25826 +4
==========================================
+ Hits 19239 19264 +25
+ Misses 4864 4849 -15
+ Partials 1719 1713 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: disksing [email protected]
What problem does this PR solve?
Fix #4001
What is changed and how it works?
When regions are marked
nomerge
, don't merge them.Also fixed an unstable test.
Check List
Tests
Release note