Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: adjust hot region config when pd-ctl return (#3982) #3992

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3982

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

adjust hot region config when pd-ctl return,ensure that the return result of pd-ctl is consistent with the actual running scheduler

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

None.

* adjust config when pd-ctl return

Signed-off-by: lhy1024 <[email protected]>

* address comments

Signed-off-by: lhy1024 <[email protected]>

* address comments

Signed-off-by: lhy1024 <[email protected]>

* address comments

Signed-off-by: lhy1024 <[email protected]>

* address comment

Signed-off-by: lhy1024 <[email protected]>

* address comment

Signed-off-by: lhy1024 <[email protected]>

* address comment

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: 混沌DM <[email protected]>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 16, 2021
@lhy1024
Copy link
Contributor

lhy1024 commented Aug 16, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 3562c21

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2021
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #3992 (3562c21) into release-5.2 (4bf6b18) will increase coverage by 0.02%.
The diff coverage is 96.36%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.2    #3992      +/-   ##
===============================================
+ Coverage        74.62%   74.64%   +0.02%     
===============================================
  Files              248      248              
  Lines            25493    25523      +30     
===============================================
+ Hits             19024    19052      +28     
- Misses            4778     4779       +1     
- Partials          1691     1692       +1     
Flag Coverage Δ
unittests 74.64% <96.36%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 83.10% <75.00%> (-0.62%) ⬇️
pkg/mock/mockcluster/mockcluster.go 95.26% <100.00%> (+0.01%) ⬆️
server/schedulers/hot_region_config.go 92.00% <100.00%> (+2.60%) ⬆️
tests/pdctl/helper.go 100.00% <100.00%> (ø)
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/region_syncer/server.go 83.08% <0.00%> (-5.89%) ⬇️
server/statistics/hot_cache_task.go 75.00% <0.00%> (-4.17%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/cluster/coordinator.go 72.91% <0.00%> (-0.68%) ⬇️
server/cluster/cluster.go 82.33% <0.00%> (-0.36%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf6b18...3562c21. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 4c176e8 into tikv:release-5.2 Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/scheduler Scheduler logic. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants