-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: adjust hot region config when pd-ctl return (#3982) #3992
scheduler: adjust hot region config when pd-ctl return (#3982) #3992
Conversation
* adjust config when pd-ctl return Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * address comment Signed-off-by: lhy1024 <[email protected]> * address comment Signed-off-by: lhy1024 <[email protected]> * address comment Signed-off-by: lhy1024 <[email protected]> Co-authored-by: 混沌DM <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 3562c21
|
Codecov Report
@@ Coverage Diff @@
## release-5.2 #3992 +/- ##
===============================================
+ Coverage 74.62% 74.64% +0.02%
===============================================
Files 248 248
Lines 25493 25523 +30
===============================================
+ Hits 19024 19052 +28
- Misses 4778 4779 +1
- Partials 1691 1692 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is an automated cherry-pick of #3982
Signed-off-by: lhy1024 [email protected]
What problem does this PR solve?
adjust hot region config when pd-ctl return,ensure that the return result of pd-ctl is consistent with the actual running scheduler
What is changed and how it works?
Check List
Tests
Release note