Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: consider evict leader when calc expect (#3967) #3977

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3967

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

fix #3959

What is changed and how it works?

  1. consider evict leader when calc expect
  2. reduce the pending amp factor
  3. unify qps and query as query, to ensure consistency with the documentation pd-control: add new config of balance-hot-region-scheduler pingcap/docs-cn#6835

Check List

Tests

  • Unit test

Related changes

Release note

None.

Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 12, 2021
@ti-chi-bot ti-chi-bot added component/scheduler Scheduler logic. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick. labels Aug 12, 2021
@ti-chi-bot ti-chi-bot requested review from disksing and nolouch August 12, 2021 07:09
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2021
@purelind
Copy link
Contributor

/run-build

@purelind
Copy link
Contributor

/run-unit-test

@purelind
Copy link
Contributor

/rebuild

1 similar comment
@purelind
Copy link
Contributor

/rebuild

@nolouch
Copy link
Contributor

nolouch commented Aug 12, 2021

/merg

@nolouch
Copy link
Contributor

nolouch commented Aug 12, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 6d2e925

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-5.2@70274be). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head caa5d7a differs from pull request most recent head 423f7ad. Consider uploading reports for the commit 423f7ad to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##             release-5.2    #3977   +/-   ##
==============================================
  Coverage               ?   74.55%           
==============================================
  Files                  ?      248           
  Lines                  ?    25484           
  Branches               ?        0           
==============================================
  Hits                   ?    18999           
  Misses                 ?     4791           
  Partials               ?     1694           
Flag Coverage Δ
unittests 74.55% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70274be...423f7ad. Read the comment docs.

@nolouch
Copy link
Contributor

nolouch commented Aug 12, 2021

/rebuild

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 12, 2021
@nolouch
Copy link
Contributor

nolouch commented Aug 13, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 8f2b816 into tikv:release-5.2 Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/scheduler Scheduler logic. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants