Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labeler: add region label #3968

Merged
merged 6 commits into from
Aug 17, 2021
Merged

labeler: add region label #3968

merged 6 commits into from
Aug 17, 2021

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing [email protected]

What problem does this PR solve?

Add labeler implementation and support key-range type label rule.

#3839

Check List

Tests

  • Unit test

Release note

None

@disksing disksing added the component/schedule Scheduling logic. label Aug 12, 2021
@disksing disksing requested a review from rleungx August 12, 2021 04:46
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #3968 (f032c6c) into master (7a2ab50) will decrease coverage by 0.02%.
The diff coverage is 79.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3968      +/-   ##
==========================================
- Coverage   74.70%   74.67%   -0.03%     
==========================================
  Files         250      251       +1     
  Lines       25548    25673     +125     
==========================================
+ Hits        19085    19172      +87     
- Misses       4775     4799      +24     
- Partials     1688     1702      +14     
Flag Coverage Δ
unittests 74.67% <79.20%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/labeler/labeler.go 78.68% <78.68%> (ø)
server/core/storage.go 68.04% <100.00%> (+0.36%) ⬆️
server/region_syncer/server.go 83.08% <0.00%> (-5.89%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/tso/tso.go 62.43% <0.00%> (-2.77%) ⬇️
server/server.go 70.51% <0.00%> (-1.52%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
server/schedule/operator_controller.go 84.75% <0.00%> (-0.80%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-0.67%) ⬇️
server/cluster/cluster.go 82.33% <0.00%> (-0.36%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2ab50...f032c6c. Read the comment docs.

Signed-off-by: disksing <[email protected]>
@disksing disksing requested a review from nolouch August 12, 2021 04:59
Signed-off-by: disksing <[email protected]>
@nolouch nolouch requested review from lhy1024 and JmPotato and removed request for lhy1024 August 16, 2021 05:28
Signed-off-by: disksing <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2021
@disksing disksing requested a review from JmPotato August 17, 2021 04:12
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 17, 2021
@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4571e0f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2021
@ti-chi-bot
Copy link
Member

@disksing: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7ca4ca9 into tikv:master Aug 17, 2021
@disksing disksing deleted the labeler1 branch August 17, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants