Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix inaccurate statistics and config (#3949) #3965

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3949

Signed-off-by: HunDunDM [email protected]

What problem does this PR solve?

What is changed and how it works?

  • scheduler: fix inaccurate statistics and config

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 11, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved priority/P1 The issue has P1 priority. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick. labels Aug 11, 2021
@ti-chi-bot ti-chi-bot requested review from disksing and lhy1024 August 11, 2021 13:37
@HunDunDM HunDunDM added this to the v5.1.2 milestone Aug 11, 2021
@disksing disksing removed their request for review August 24, 2021 03:09
@HunDunDM
Copy link
Member

pre PR is #4051

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 13, 2021
@HunDunDM
Copy link
Member

A small amount of code for #3833 will be introduced.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2021
@HunDunDM HunDunDM force-pushed the cherry-pick-3949-to-release-5.1 branch from 2a9b3a8 to 421d622 Compare September 15, 2021 13:04
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2021
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 15, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 421d622

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2021
@nolouch
Copy link
Contributor

nolouch commented Sep 15, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #3965 (421d622) into release-5.1 (2b8584e) will increase coverage by 0.03%.
The diff coverage is 95.91%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.1    #3965      +/-   ##
===============================================
+ Coverage        75.14%   75.18%   +0.03%     
===============================================
  Files              245      245              
  Lines            24657    24673      +16     
===============================================
+ Hits             18529    18550      +21     
+ Misses            4504     4502       -2     
+ Partials          1624     1621       -3     
Flag Coverage Δ
unittests 75.18% <95.91%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 86.37% <95.00%> (+0.24%) ⬆️
server/schedulers/hot_region_config.go 82.47% <100.00%> (+0.55%) ⬆️
server/schedulers/utils.go 94.17% <100.00%> (+0.02%) ⬆️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/schedulers/random_merge.go 60.65% <0.00%> (-3.28%) ⬇️
server/tso/allocator_manager.go 76.79% <0.00%> (-2.18%) ⬇️
server/cluster/coordinator.go 73.31% <0.00%> (-0.73%) ⬇️
client/client.go 71.96% <0.00%> (+0.13%) ⬆️
pkg/btree/btree.go 86.26% <0.00%> (+0.48%) ⬆️
server/schedule/operator/step.go 69.10% <0.00%> (+0.66%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8584e...421d622. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 48b3ffd into tikv:release-5.1 Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. priority/P1 The issue has P1 priority. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants