Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: use the store qps stats in the hot-write-leader-balance #3948

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

HunDunDM
Copy link
Member

@HunDunDM HunDunDM commented Aug 3, 2021

Signed-off-by: HunDunDM [email protected]

What problem does this PR solve?

What is changed and how it works?

scheduler: use the store qps stats in the hot-write-leader-balance

Check List

Tests

Code changes

Side effects

Related changes

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 3, 2021
@ti-chi-bot ti-chi-bot requested review from disksing and rleungx August 3, 2021 12:20
@HunDunDM HunDunDM changed the title scheduler: use the stats reported by the store in the hot-write-leader-balance scheduler: use the store qps stats in the hot-write-leader-balance Aug 3, 2021
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2021
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #3948 (e11fe3f) into master (c06414f) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3948      +/-   ##
==========================================
+ Coverage   74.48%   74.75%   +0.27%     
==========================================
  Files         246      246              
  Lines       25072    25073       +1     
==========================================
+ Hits        18675    18744      +69     
+ Misses       4730     4684      -46     
+ Partials     1667     1645      -22     
Flag Coverage Δ
unittests 74.75% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 86.93% <100.00%> (+0.01%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-25.00%) ⬇️
server/member/member.go 63.10% <0.00%> (-1.61%) ⬇️
server/cluster/cluster.go 83.01% <0.00%> (+0.11%) ⬆️
server/grpc_service.go 47.68% <0.00%> (+0.22%) ⬆️
server/cluster/coordinator.go 74.12% <0.00%> (+0.69%) ⬆️
server/core/storage.go 68.44% <0.00%> (+0.76%) ⬆️
server/schedule/operator/step.go 69.76% <0.00%> (+1.66%) ⬆️
server/tso/allocator_manager.go 68.61% <0.00%> (+2.17%) ⬆️
server/server.go 72.94% <0.00%> (+2.43%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c06414f...e11fe3f. Read the comment docs.

@HunDunDM
Copy link
Member Author

HunDunDM commented Aug 3, 2021

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e11fe3f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2021
@ti-chi-bot ti-chi-bot merged commit e23a9e5 into tikv:master Aug 3, 2021
@HunDunDM HunDunDM deleted the write-leader-store-qps branch August 3, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants