-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: use the store qps stats in the hot-write-leader-balance #3948
Conversation
…r-balance Signed-off-by: HunDunDM <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #3948 +/- ##
==========================================
+ Coverage 74.48% 74.75% +0.27%
==========================================
Files 246 246
Lines 25072 25073 +1
==========================================
+ Hits 18675 18744 +69
+ Misses 4730 4684 -46
+ Partials 1667 1645 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: e11fe3f
|
Signed-off-by: HunDunDM [email protected]
What problem does this PR solve?
What is changed and how it works?
scheduler: use the store qps stats in the hot-write-leader-balance
Check List
Tests
Code changes
Side effects
Related changes
Release note