Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: scatter regions to stores with the same engine (#2531) #2706

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2531 to release-4.0


What problem does this PR solve?

Fixes #2485

What is changed and how it works?

This PR stores scattering information by engine in engineContext. Then, we do scattering only within stores with the same engine. I think it should help tiflash scatter its regions.

Check List

Tests

  • Unit test

Side effects

  • Possible performance regression
    • The scattering is more complex now. But I think it shouldn't be a big problem because it's rare to do this operation.

Related changes

  • Need to cherry-pick to the release branch (?)

Release note

Support scattering regions in stores with special engines (like TiFlash).

@ti-srebot
Copy link
Contributor Author

@sticnarf please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/pd/invitations

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2020
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2020
@rleungx
Copy link
Member

rleungx commented Aug 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 238b9c1 into tikv:release-4.0 Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants