tso: fix the bug that TSO request may fail at the time of leader changing (#2665) #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
ti-srebot
added
contribution
lhy1024
approved these changes
Jul 20, 2020
ti-srebot
added
status/LGT1
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2666 +/- ##
===============================================
- Coverage 77.16% 77.13% -0.04%
===============================================
Files 204 205 +1
Lines 21940 22207 +267
===============================================
+ Hits 16931 17130 +199
- Misses 3724 3768 +44
- Partials 1285 1309 +24
Continue to review full report at Codecov.
|
JmPotato
approved these changes
Jul 20, 2020
|
@JmPotato,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack). |
disksing
approved these changes
Jul 20, 2020
ti-srebot
added
status/LGT2
|
/merge |
|
Sorry @disksing, you don't have permission to trigger auto merge event on this branch. |
ti-srebot
added
status/LGT3
ti-srebot
added
status/LGT4
|
/run-integration-common-test |
|
/run-integration-compatibility-test |
|
/run-integration-ddl-test |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2665 to release-4.0
Signed-off-by: JmPotato [email protected]
Close #2663
What problem does this PR solve?
Under the current latest version of PD, TSO request may fail at the time of leader changing because
SyncTimestampis not yet completed but PD receives a TSO request at the same time.What is changed and how it works?
Add leader lease check and try to sleep a while to wait for
SyncTimestamp.Check List
Tests
Code changes
GetRespTSmethod changeRelated changes
Release note
Fix the bug that TSO request may fail at the time of leader changing.