server: Fix bug for region_score with store's used_size is zero #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JaySon-Huang <[email protected]>
|
|
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
JaySon-Huang
changed the title
|
@JaySon-Huang Can you tell more about why the used size is 0? |
Signed-off-by: JaySon-Huang <[email protected]>
|
@rleungx It is detected by a special version of TiFlash, which report zero bytes used with non-zero regions. |
nolouch
approved these changes
May 28, 2020
nolouch
added
type/bugfix
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-4.0 in PR #2474 |
sre-bot
pushed a commit
that referenced
this pull request
May 29, 2020
… (#2477) Signed-off-by: JaySon-Huang <[email protected]>
sre-bot
added a commit
that referenced
this pull request
May 30, 2020
… (#2474) Signed-off-by: JaySon-Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang [email protected]
What problem does this PR solve?
Fix #2470
What is changed and how it works?
If store's used size is zero, just set
amplification = 1to avoid divide by zero error.Check List
Tests
Related changes
Release note