Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistic: add moving average for stable hot #2286

Merged
merged 5 commits into from
Mar 28, 2020
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Mar 27, 2020

What problem does this PR solve?

It will denoise and make statistics more stable. Below is a contrast between before and after.

image

What is changed and how it works?

We use average overtime to solve the problem that interval is different.
And add another moving average to filter out high-frequency noise.

Release note

Add moving average to make flow statistics more stable.

Check List

Tests

  • Unit test

@lhy1024 lhy1024 added the component/schedule Scheduling logic. label Mar 27, 2020
@lhy1024 lhy1024 requested review from nolouch and rleungx March 27, 2020 05:45
@nolouch
Copy link
Contributor

nolouch commented Mar 27, 2020

@lhy1024 ci failed.

@nolouch nolouch added this to the v4.0.0-rc milestone Mar 28, 2020
@nolouch nolouch added the priority/P1 The issue has P1 priority. label Mar 28, 2020
@nolouch
Copy link
Contributor

nolouch commented Mar 28, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 28, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 28, 2020

@lhy1024 merge failed.

@nolouch nolouch merged commit 396d23c into tikv:master Mar 28, 2020
nolouch pushed a commit to nolouch/pd that referenced this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. priority/P1 The issue has P1 priority. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants