Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add config check mechanism #2049

Merged
merged 6 commits into from
Jan 17, 2020
Merged

*: add config check mechanism #2049

merged 6 commits into from
Jan 17, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 24, 2019

What problem does this PR solve?

Since we use the config manager to manage the configuration of all components. PD also should support it. It can be reviewed after #2041 is merged.

What is changed and how it works?

This PR adds a new goroutine to register config to the config manager and get the update from the config manager to apply it locally.

Check List

Tests

  • Unit test

@rleungx rleungx added the component/config Configuration logic. label Dec 24, 2019
@rleungx rleungx added this to the v4.0.0-beta milestone Dec 24, 2019
@codecov-io
Copy link

codecov-io commented Dec 24, 2019

Codecov Report

Merging #2049 into master will decrease coverage by 0.11%.
The diff coverage is 45.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2049      +/-   ##
==========================================
- Coverage      77%   76.89%   -0.12%     
==========================================
  Files         194      194              
  Lines       19572    19724     +152     
==========================================
+ Hits        15072    15166      +94     
- Misses       3366     3427      +61     
+ Partials     1134     1131       -3
Impacted Files Coverage Δ
server/config/config.go 87.5% <ø> (ø) ⬆️
server/config/option.go 87.44% <42.85%> (-3.8%) ⬇️
server/server.go 75.51% <45.65%> (-8.01%) ⬇️
server/schedulers/shuffle_hot_region.go 64.58% <0%> (-5.21%) ⬇️
client/base_client.go 84.82% <0%> (-2.76%) ⬇️
client/config_client.go 54.54% <0%> (-2.03%) ⬇️
client/client.go 67.92% <0%> (-0.54%) ⬇️
server/member/leader.go 78.06% <0%> (-0.52%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541e3a5...d2fdea9. Read the comment docs.

Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rleungx rleungx removed this from the v4.0.0-beta milestone Jan 9, 2020
server/server.go Outdated Show resolved Hide resolved
Copy link
Member

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
Copy link
Member Author

rleungx commented Jan 17, 2020

/run-all-tests

@rleungx
Copy link
Member Author

rleungx commented Jan 17, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 17, 2020

/run-all-tests

@sre-bot sre-bot merged commit 19abe28 into tikv:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config Configuration logic. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants