-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add config check mechanism #2049
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2049 +/- ##
==========================================
- Coverage 77% 76.89% -0.12%
==========================================
Files 194 194
Lines 19572 19724 +152
==========================================
+ Hits 15072 15166 +94
- Misses 3366 3427 +61
+ Partials 1134 1131 -3
Continue to review full report at Codecov.
|
60f21ff
to
fea7ad6
Compare
d45e1aa
to
f507017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
/run-all-tests |
/merge |
/run-all-tests |
What problem does this PR solve?
Since we use the config manager to manage the configuration of all components. PD also should support it. It can be reviewed after #2041 is merged.
What is changed and how it works?
This PR adds a new goroutine to register config to the config manager and get the update from the config manager to apply it locally.
Check List
Tests