Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: log format for server #1431

Merged
merged 6 commits into from
Feb 19, 2019
Merged

*: log format for server #1431

merged 6 commits into from
Feb 19, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Feb 14, 2019

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

Format the log according to our RFC.

What is changed and how it works?

This PR is going to do the log format for server packages.

Check List

Tests

  • Unit test

@nolouch nolouch requested review from disksing and rleungx February 15, 2019 05:39
@codecov-io
Copy link

codecov-io commented Feb 15, 2019

Codecov Report

Merging #1431 into master will decrease coverage by 0.02%.
The diff coverage is 62.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
- Coverage   67.67%   67.64%   -0.03%     
==========================================
  Files         158      158              
  Lines       15076    15146      +70     
==========================================
+ Hits        10203    10246      +43     
- Misses       3955     3968      +13     
- Partials      918      932      +14
Impacted Files Coverage Δ
server/version.go 72.72% <0%> (ø) ⬆️
server/etcd_kv.go 63.63% <0%> (-10.91%) ⬇️
server/grpc_service.go 53.51% <100%> (+0.34%) ⬆️
server/systime_mon.go 100% <100%> (ø) ⬆️
server/id.go 72.97% <100%> (ø) ⬆️
server/heartbeat_streams.go 76.82% <16.66%> (-2.92%) ⬇️
server/handler.go 55.14% <20%> (ø) ⬆️
server/join.go 55.4% <33.33%> (ø) ⬆️
server/tso.go 72.72% <37.5%> (-1.7%) ⬇️
server/cluster.go 79.88% <58.33%> (-0.94%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376c933...a180ff5. Read the comment docs.

@nolouch nolouch added the component/log Log. label Feb 18, 2019
@nolouch
Copy link
Contributor Author

nolouch commented Feb 18, 2019

/rebuild

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

server/cluster_info.go Outdated Show resolved Hide resolved
server/leader.go Outdated Show resolved Hide resolved
server/join.go Outdated Show resolved Hide resolved
server/join.go Outdated Show resolved Hide resolved
server/heartbeat_stream_test.go Outdated Show resolved Hide resolved
server/coordinator.go Outdated Show resolved Hide resolved
server/cluster_info.go Outdated Show resolved Hide resolved
server/cluster_info.go Outdated Show resolved Hide resolved
server/cluster_info.go Outdated Show resolved Hide resolved
server/cluster_info.go Outdated Show resolved Hide resolved
Copy link
Contributor

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

server/cluster_info.go Outdated Show resolved Hide resolved
server/grpc_service.go Outdated Show resolved Hide resolved
Signed-off-by: nolouch <[email protected]>
@nolouch nolouch merged commit 5e81548 into tikv:master Feb 19, 2019
@nolouch nolouch deleted the server-log branch February 19, 2019 11:14
nolouch added a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* *: log format for server

Signed-off-by: nolouch <[email protected]>
nolouch added a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* *: log format for server

Signed-off-by: nolouch <[email protected]>
nolouch added a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* *: log format for server

Signed-off-by: nolouch <[email protected]>
nolouch added a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* *: log format for server

Signed-off-by: nolouch <[email protected]>
youjiali1995 pushed a commit that referenced this pull request Jul 17, 2019
* *:Start swithing to the zap logger (#1422)

Signed-off-by: nolouch <[email protected]>

* *: log format for schedule, scheduler, syncer, api (#1423)

* log format for schedule, scheduler, syncer, api

Signed-off-by: rleungx <[email protected]>

* pdctl, api: support hex format keys (#1309)

pdctl, api: support hex format keys

Signed-off-by: disksing <[email protected]>

* *: log format for tools, client, pkg, table (#1424)

* log format for tools, client, pkg, table, simulator

Signed-off-by: rleungx <[email protected]>

* *: log format for server (#1431)

* *: log format for server

Signed-off-by: nolouch <[email protected]>

* *: log format for logutil, server/core (#1438)

* *: log format for logutil,server/core

* *: improve some logs (#1516)

* improve some logs

Signed-off-by: Ryan Leung <[email protected]>

* log: do not add stack to error log (#1532)

* pkg, tools: improve the log message (#1636)

* pkg,tools: improve the log message

Signed-off-by: nolouch <[email protected]>

* core: use hex format for region meta key (#1627)

Signed-off-by: Ryan Leung <[email protected]>=

* address comments

Signed-off-by: nolouch <[email protected]>

* address comments

Signed-off-by: nolouch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants