-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make some region_command support jq #1420
Conversation
Signed-off-by: fredchenbj <[email protected]>
Signed-off-by: fredchenbj <[email protected]>
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
1 similar comment
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
=========================================
Coverage ? 67.44%
=========================================
Files ? 157
Lines ? 14820
Branches ? 0
=========================================
Hits ? 9996
Misses ? 3892
Partials ? 932
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What problem does this PR solve?
make some region_command, such as
region topwrite
support--jq
.Tests
Side effects
See above, it ouputs unexpected message "unknown flag: --jq".