Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd-ctl should return non-zero exit code on error #8762

Open
cjc7373 opened this issue Nov 4, 2024 · 1 comment
Open

pd-ctl should return non-zero exit code on error #8762

cjc7373 opened this issue Nov 4, 2024 · 1 comment
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@cjc7373
Copy link

cjc7373 commented Nov 4, 2024

Enhancement Task

In some automated scripts, it is hard to tell if a command succeeds because pd-ctl returns 0 on error.

For example:

[root@tidb-cluster-tikv-0 /]# /pd-ctl -u "$PD_ADDRESS" store delete addr ""
address not found: 
[root@tidb-cluster-tikv-0 /]# echo $?
0
@cjc7373 cjc7373 added the type/enhancement The issue or PR belongs to an enhancement. label Nov 4, 2024
@rleungx
Copy link
Member

rleungx commented Nov 6, 2024

PTAL @JackL9u

This was referenced Nov 7, 2024
Closed
Closed
Merged
ti-chi-bot bot added a commit that referenced this issue Nov 12, 2024
@JackL9u @ti-chi-bot
store_command: propagate the error code to the root command (#8798)
bb4c437 
ref #8762

Signed-off-by: Boyang Lyu <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjc7373 @rleungx