Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdms: after scale out, online number can't return to 0 even if cluster is balance #8331

Closed
mayjiang0203 opened this issue Jun 26, 2024 · 2 comments · Fixed by #8334
Closed

pdms: after scale out, online number can't return to 0 even if cluster is balance #8331

mayjiang0203 opened this issue Jun 26, 2024 · 2 comments · Fixed by #8334
Assignees
@rleungx
Labels
affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@mayjiang0203
Copy link

Bug Report

What did you do?

What did you expect to see?

What did you see instead?

583a7319-6406-46e9-be71-1ed0c0264d4c

b4e4c0e3-c483-49e4-b420-a36044e120a0

What version of PD are you using (pd-server -V)?

master
@mayjiang0203 mayjiang0203 added the type/bug The issue is confirmed as a bug. label Jun 26, 2024
@mayjiang0203
Copy link
Author

/severity major
/assign @rleungx

@rleungx
Copy link
Member

rleungx commented Jun 26, 2024

The problem is before we calculate the progress, we need to check if the prepare checker is prepared. But if we deploy scheduling as an independent service, the prepare checker will never run, which skips the progress calculation.

@rleungx rleungx mentioned this issue Jun 27, 2024
Merged
@rleungx rleungx added the affects-8.1 This bug affects the 8.1.x(LTS) versions. label Jun 27, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in d29fd1a Jun 28, 2024
@ti-chi-bot ti-chi-bot mentioned this issue Jul 31, 2024
Merged
ti-chi-bot bot added a commit that referenced this issue Jul 31, 2024
@ti-chi-bot @rleungx @ti-chi-bot
schedule: fix progress cannot display when enabling scheduling service (
9fe738a 
#8334) (#8471)

close #8331

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rleungx rleungx

Labels
affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

schedule: fix progress cannot display when enabling scheduling service rleungx/pd
2 participants
@mayjiang0203 @rleungx