Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect test TestReloadLabel #8310

Closed
okJiang opened this issue Jun 20, 2024 · 1 comment · Fixed by #8311
Closed

Incorrect test TestReloadLabel #8310

okJiang opened this issue Jun 20, 2024 · 1 comment · Fixed by #8311
Labels
type/ci The issue is related to CI.

Comments

@okJiang
Copy link
Member

okJiang commented Jun 20, 2024 •
edited
Loading

pd/tests/integrations/realcluster/reboot_pd_test.go

Lines 69 to 71 in 9804702

for _, label := range store.Store.Labels {
re.Equal(label.Value, storeLabel[label.Key])
}

store.Store.Labels should be storeLabels
@ti-chi-bot ti-chi-bot bot added the needs-type Indicates an issue requires a type label. label Jun 20, 2024
@okJiang
Copy link
Member Author

okJiang commented Jun 20, 2024

/type bug

@ti-chi-bot ti-chi-bot bot added type/bug The issue is confirmed as a bug. and removed needs-type Indicates an issue requires a type label. labels Jun 20, 2024
@rleungx rleungx added type/ci The issue is related to CI. and removed type/bug The issue is confirmed as a bug. labels Jun 20, 2024
@okJiang okJiang mentioned this issue Jun 20, 2024
Merged
@HuSharp HuSharp mentioned this issue Jun 20, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 20, 2024
@HuSharp
tests/real_cluster: refine reboot cluster (#8311)
8c2bb02 
close #8310

Signed-off-by: husharp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/ci The issue is related to CI.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests/real_cluster: refine reboot cluster HuSharp/pd
2 participants
@okJiang @rleungx