Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The removed member should no longer appear in the list of evicted endpoints #8286

Closed
JmPotato opened this issue Jun 14, 2024 · 0 comments · Fixed by #8287
Closed

The removed member should no longer appear in the list of evicted endpoints #8286

JmPotato opened this issue Jun 14, 2024 · 0 comments · Fixed by #8287
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@JmPotato
Copy link
Member

Bug Report

[2024/06/04 15:07:36.180 +05:30] [INFO] [health_checker.go:386] ["remove stale etcd client"] [endpoint=http://{pd_addr_a}:2379] [source=election-etcd-client]
...
[2024/06/04 15:07:45.167 +05:30] [INFO] [health_checker.go:294] ["evicted etcd endpoint found"] [endpoint=http://{pd_addr_a}:2379] [source=election-etcd-client]

Once a member is removed from the cluster, its endpoint should no longer exist in the health checker.
@JmPotato JmPotato added type/bug The issue is confirmed as a bug. severity/moderate labels Jun 14, 2024
@JmPotato JmPotato mentioned this issue Jun 14, 2024
Merged
@JmPotato JmPotato added affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Jun 14, 2024
ti-chi-bot bot added a commit that referenced this issue Jun 14, 2024
@JmPotato @ti-chi-bot
etcdutil: check if the endpoint has been removed before evicting (#8287)
463aee9 
close #8286

Once a member is removed from the cluster, its endpoint should no longer exist in the health checker.
This PR adds a check to prevent the removed endpoint from being evicted again unexpectedly.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
This was referenced Jun 14, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 14, 2024
@ti-chi-bot @JmPotato
etcdutil: check if the endpoint has been removed before evicting (#8287…
e8fdd58 
…) (#8290)

close #8286

Once a member is removed from the cluster, its endpoint should no longer exist in the health checker.
This PR adds a check to prevent the removed endpoint from being evicted again unexpectedly.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
ti-chi-bot bot pushed a commit that referenced this issue Jun 14, 2024
@ti-chi-bot @JmPotato
etcdutil: check if the endpoint has been removed before evicting (#8287…
162e597 
…) (#8291)

close #8286

Once a member is removed from the cluster, its endpoint should no longer exist in the health checker.
This PR adds a check to prevent the removed endpoint from being evicted again unexpectedly.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/moderate type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

etcdutil: check if the endpoint has been removed before evicting JmPotato/pd
1 participant
@JmPotato