Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When PD leader is transferred and there is network partition between new leader and pd client, client can't work #7416

Closed
CabinfeverB opened this issue Nov 22, 2023 · 1 comment · Fixed by #7443
Closed

When PD leader is transferred and there is network partition between new leader and pd client, client can't work #7416

CabinfeverB opened this issue Nov 22, 2023 · 1 comment · Fixed by #7443
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@CabinfeverB
Copy link
Member

CabinfeverB commented Nov 22, 2023 •
edited
Loading

Bug Report

can reproduce by test in #7443.

What did you do?

"tidb": "enable-forwarding = true" (affects pd client)
inject network partition between one of tidb and pd follower A last for 10m
transfer leader to pd A

What did you expect to see?

tidb works normally

What did you see instead?

tidb can't work normally

What version of PD are you using (pd-server -V)?

master
@CabinfeverB CabinfeverB added type/bug The issue is confirmed as a bug. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Nov 22, 2023
@CabinfeverB
Copy link
Member Author

This kind of error is rare in the production environment. I want to fix it later

@CabinfeverB CabinfeverB mentioned this issue Nov 27, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Nov 29, 2023
@CabinfeverB @ti-chi-bot
client: update the leader even if the connection creation fails (#7443)
54bf70e 
close #7416

Signed-off-by: Cabinfever_B <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 29, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 29, 2023
@CabinfeverB @ti-chi-bot
This is an automated cherry-pick of tikv#7443
de73256 
close tikv#7416

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 29, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 29, 2023
@CabinfeverB @ti-chi-bot
This is an automated cherry-pick of tikv#7443
3ccdd83 
close tikv#7416

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 29, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 29, 2023
@CabinfeverB @ti-chi-bot
This is an automated cherry-pick of tikv#7443
fd578d2 
close tikv#7416

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 29, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Dec 6, 2023
@ti-chi-bot @CabinfeverB @ti-chi-bot
client: update the leader even if the connection creation fails (#7443)…
0b048b1 
… (#7475)

close #7416

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>

Co-authored-by: Yongbo Jiang <[email protected]>
Co-authored-by: Cabinfever_B <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@niubell niubell mentioned this issue Dec 13, 2023
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 25, 2023
@ti-chi-bot @CabinfeverB
client: update the leader even if the connection creation fails (#7443)…
8ea0f6f 
… (#7476)

close #7416

Signed-off-by: Cabinfever_B <[email protected]>

Co-authored-by: Cabinfever_B <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/moderate type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: update the leader even if the connection creation fails CabinfeverB/pd
1 participant
@CabinfeverB