Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swagger: curl /swagger/* return 404 if swagger server is disabled #6786

Closed
bufferflies opened this issue Jul 12, 2023 · 0 comments · Fixed by #6785
Closed

swagger: curl /swagger/* return 404 if swagger server is disabled #6786

bufferflies opened this issue Jul 12, 2023 · 0 comments · Fixed by #6785
Assignees
@bufferflies
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement.

Comments

@bufferflies
Copy link
Contributor

Enhancement Task

In past, it returns 200 if swager server is disabled. some user thinks this urls are not safe.
image
@bufferflies bufferflies added the type/enhancement The issue or PR belongs to an enhancement. label Jul 12, 2023
@bufferflies bufferflies mentioned this issue Jul 12, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jul 12, 2023
@bufferflies
swagger: block swagger url if disbale swagger server (#6785)
c07c333 
close #6786

/swagger/* return 404

Signed-off-by: bufferflies <[email protected]>
This was referenced Jul 12, 2023
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jul 12, 2023
@bufferflies @ti-chi-bot
This is an automated cherry-pick of tikv#6785
2552312 
close tikv#6786

Signed-off-by: ti-chi-bot <[email protected]>
@bufferflies bufferflies added type/bug The issue is confirmed as a bug. severity/minor labels Jul 12, 2023
@bufferflies bufferflies self-assigned this Jul 12, 2023
@nolouch nolouch added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Jul 12, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jul 12, 2023
@ti-chi-bot @bufferflies
swagger: block swagger url if disbale swagger server (#6785) (#6790)
61a7f07 
close #6786

/swagger/* return 404

Signed-off-by: bufferflies <[email protected]>

Co-authored-by: bufferflies <[email protected]>
ti-chi-bot bot pushed a commit that referenced this issue Jul 14, 2023
@ti-chi-bot @bufferflies
swagger: block swagger url if disbale swagger server (#6785) (#6789)
f427242 
close #6786

/swagger/* return 404

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: bufferflies <[email protected]>

Co-authored-by: buffer <[email protected]>
Co-authored-by: bufferflies <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bufferflies bufferflies

Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

swagger: block swagger url if disbale swagger server bufferflies/pd
2 participants
@nolouch @bufferflies