Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource control is not ideal when the request load from different resource group is unbalanced #6335

Open
Tracked by #43180
Connor1996 opened this issue Apr 18, 2023 · 0 comments · Fixed by #6336
Open
Tracked by #43180

Resource control is not ideal when the request load from different resource group is unbalanced #6335

Connor1996 opened this issue Apr 18, 2023 · 0 comments · Fixed by #6336
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@Connor1996
Copy link
Member

Enhancement Task

Consider the case that there are 3 stores, and the request load from one resource group is a hotspot workload. Then all requests from the resource group are handled on one store whereas the requests from the other resource group are distributed evenly on all stores.

As resource control on TiKV only has the local resource consumption, the local QPS ratio may meet the ratio of resource quota of different resource groups but the overall QPS ratio may not meet with skew load. To solve that, the request to one store needs to carry the resource consumption on other stores to make the overall consumption considered.
@Connor1996 Connor1996 added the type/enhancement The issue or PR belongs to an enhancement. label Apr 18, 2023
@Connor1996 Connor1996 mentioned this issue Apr 18, 2023
Merged
ti-chi-bot added a commit that referenced this issue Apr 19, 2023
@Connor1996 @ti-chi-bot
client: Count resource penalty for resource control (#6336)
9e7b8e8 
close #6335

Count the delta resource consumption of the resource group that have completed at all stores between the previous request to this store and current request.

Signed-off-by: Connor1996 <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@nolouch nolouch reopened this Apr 19, 2023
@nolouch nolouch mentioned this issue Apr 19, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: Count resource penalty for resource control Connor1996/pd
2 participants
@nolouch @Connor1996