Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some metrics should be deleted instead of setting to 0 #5163

Closed
rleungx opened this issue Jun 15, 2022 · 0 comments · Fixed by #5162
Closed

Some metrics should be deleted instead of setting to 0 #5163

rleungx opened this issue Jun 15, 2022 · 0 comments · Fixed by #5162
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@rleungx
Copy link
Member

rleungx commented Jun 15, 2022

Enhancement Task

There are metrics that should be deleted, e.g.,

pd/server/cluster/coordinator.go

Line 676 in 0da658c

schedulerStatusGauge.WithLabelValues(name, "allow").Set(0)

@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Jun 15, 2022
@rleungx rleungx mentioned this issue Jun 15, 2022
Merged
ti-chi-bot added a commit that referenced this issue Jun 16, 2022
@rleungx @ti-chi-bot
metrics: delete the metrics instead of setting them to 0 (#5162)
2efa259 
close #5163

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@rleungx @ti-chi-bot @CabinfeverB
metrics: delete the metrics instead of setting them to 0 (tikv#5162)
43ef5ea 
close tikv#5163

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics: delete the metrics instead of setting them to 0 rleungx/pd
1 participant
@rleungx