Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The error returned by PD gRPC service is not expected #5161

Closed
Tracked by #5309
rleungx opened this issue Jun 15, 2022 · 5 comments · Fixed by #5310
Closed
Tracked by #5309

The error returned by PD gRPC service is not expected #5161

rleungx opened this issue Jun 15, 2022 · 5 comments · Fixed by #5310
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Jun 15, 2022

Bug Report

See

pd/server/grpc_service.go

Line 470 in d263b85

return nil, status.Errorf(codes.Unknown, "invalid store ID %d, not found", storeID)

We should put the error into the header instead of directly returning a gRPC error.

What version of PD are you using (pd-server -V)?

master
@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Jun 15, 2022
@Connor1996 Connor1996 mentioned this issue Jun 15, 2022
Closed
@mayjiang0203
Copy link

mayjiang0203 commented Jun 21, 2022 •
edited
Loading

/Severity Minor

@mayjiang0203
Copy link

mayjiang0203 commented Jun 21, 2022 •
edited
Loading

/severity Minor

@Connor1996
Copy link
Member

@mayjiang0203 Should we level it up to major, it may cause pd client of TiKV to reconnect again and again which greatly affects the performance

@JmPotato JmPotato mentioned this issue Jul 14, 2022
Open
5 tasks
@HuSharp HuSharp mentioned this issue Jul 14, 2022
Merged
ti-chi-bot added a commit that referenced this issue Jul 21, 2022
@HuSharp @ti-chi-bot
*: put gRPC unknown error into the header. (#5310)
bde0a1b 
close #5161, ref #5161

put the unknown error into the header instead of directly returning a gRPC error.

Signed-off-by: husharp <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@rleungx rleungx reopened this Aug 10, 2022
@rleungx
Copy link
Member Author

rleungx commented Aug 10, 2022

I found there are still some errors that are not well handled.

nolouch pushed a commit to nolouch/pd that referenced this issue Jun 30, 2023
@HuSharp @ti-chi-bot @nolouch
*: put gRPC unknown error into the header. (tikv#5310)
24bb86f 
close tikv#5161, ref tikv#5161

put the unknown error into the header instead of directly returning a gRPC error.

Signed-off-by: husharp <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@nolouch nolouch mentioned this issue Jun 30, 2023
Merged
@nolouch nolouch added affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Jun 30, 2023
nolouch pushed a commit to nolouch/pd that referenced this issue Jun 30, 2023
@HuSharp @ti-chi-bot @nolouch
*: put gRPC unknown error into the header. (tikv#5310)
886f415 
close tikv#5161, ref tikv#5161

put the unknown error into the header instead of directly returning a gRPC error.

Signed-off-by: husharp <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Jun 30, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jun 30, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#5310
1584544 
close tikv#5161, ref tikv#5161

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Jun 30, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jun 30, 2023
@HuSharp @ti-chi-bot
This is an automated cherry-pick of tikv#5310
e90eb02 
close tikv#5161, ref tikv#5161

Signed-off-by: ti-chi-bot <[email protected]>
@nolouch nolouch removed affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Jun 30, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jun 30, 2023
@nolouch @HuSharp @ti-chi-bot
*: put gRPC unknown error into the header. (#5310) (#6724)
3dc0cc3 
close #5161, ref #5309, ref #5310, ref pingcap/tiflash#7408

put the unknown error into the header instead of directly returning a gRPC error.

Signed-off-by: husharp <[email protected]>

Co-authored-by: Hu# <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
@nolouch nolouch added the affects-6.5 This bug affects the 6.5.x(LTS) versions. label Jul 4, 2023
@nolouch nolouch added affects-7.1 This bug affects the 7.1.x(LTS) versions. and removed affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. labels Jul 4, 2023
@nolouch
Copy link
Contributor

nolouch commented Jul 4, 2023

ref pingcap/tiflash#7408

@nolouch nolouch closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: put gRPC unknown error into the header. HuSharp/pd
5 participants
@nolouch @mayjiang0203 @Connor1996 @rleungx @ti-chi-bot