Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer is accidently removed when scatter region #4565

Closed
rleungx opened this issue Jan 12, 2022 · 1 comment · Fixed by #4570
Closed

Peer is accidently removed when scatter region #4565

rleungx opened this issue Jan 12, 2022 · 1 comment · Fixed by #4570
Assignees
Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Jan 12, 2022

Bug Report

Screen Shot 2022-01-12 at 4 28 21 PM

What did you do?

Use API to scatter regions.

What did you expect to see?

There should be only scatter-region operators.

What did you see instead?

Screen Shot 2022-01-12 at 4 31 55 PM

What version of PD are you using (pd-server -V)?

master and v5.4.0

@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Jan 12, 2022
@jebter jebter added the affects-5.4 This bug affects the 5.4.x(LTS) versions. label Jan 12, 2022
@mayjiang0203
Copy link

/severity major

HunDunDM added a commit to HunDunDM/pd that referenced this issue Jan 13, 2022
HunDunDM added a commit to HunDunDM/pd that referenced this issue Jan 14, 2022
ti-chi-bot pushed a commit that referenced this issue Jan 14, 2022
…ew peers (#4570)

* region_scatterer: fix the bug that could generate schedule with too few peers

close #4565

Signed-off-by: HunDunDM <[email protected]>

* add test

Signed-off-by: HunDunDM <[email protected]>

* add comment

Signed-off-by: HunDunDM <[email protected]>

* fix import

Signed-off-by: HunDunDM <[email protected]>

* better select strategy

Signed-off-by: HunDunDM <[email protected]>

* tiny fix

Signed-off-by: HunDunDM <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
…ew peers (tikv#4570)

* region_scatterer: fix the bug that could generate schedule with too few peers

close tikv#4565

Signed-off-by: HunDunDM <[email protected]>

* add test

Signed-off-by: HunDunDM <[email protected]>

* add comment

Signed-off-by: HunDunDM <[email protected]>

* fix import

Signed-off-by: HunDunDM <[email protected]>

* better select strategy

Signed-off-by: HunDunDM <[email protected]>

* tiny fix

Signed-off-by: HunDunDM <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
…ew peers (tikv#4570)

* region_scatterer: fix the bug that could generate schedule with too few peers

close tikv#4565

Signed-off-by: HunDunDM <[email protected]>

* add test

Signed-off-by: HunDunDM <[email protected]>

* add comment

Signed-off-by: HunDunDM <[email protected]>

* fix import

Signed-off-by: HunDunDM <[email protected]>

* better select strategy

Signed-off-by: HunDunDM <[email protected]>

* tiny fix

Signed-off-by: HunDunDM <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
…ew peers (tikv#4570)

* region_scatterer: fix the bug that could generate schedule with too few peers

close tikv#4565

Signed-off-by: HunDunDM <[email protected]>

* add test

Signed-off-by: HunDunDM <[email protected]>

* add comment

Signed-off-by: HunDunDM <[email protected]>

* fix import

Signed-off-by: HunDunDM <[email protected]>

* better select strategy

Signed-off-by: HunDunDM <[email protected]>

* tiny fix

Signed-off-by: HunDunDM <[email protected]>
HunDunDM added a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
HunDunDM added a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
HunDunDM added a commit to ti-chi-bot/pd that referenced this issue Jan 14, 2022
ti-chi-bot added a commit that referenced this issue Jan 21, 2022
…ew peers (#4570) (#4579)

* region_scatterer: fix the bug that could generate schedule with too few peers (#4570)

close #4565

Signed-off-by: HunDunDM <[email protected]>

* region_scatterer: fix incorrect test (#4586)

Signed-off-by: HunDunDM <[email protected]>

Co-authored-by: HunDunDM <[email protected]>
disksing pushed a commit to oh-my-tidb/pd that referenced this issue Feb 8, 2022
…ew peers (tikv#4570)

* region_scatterer: fix the bug that could generate schedule with too few peers

close tikv#4565

Signed-off-by: HunDunDM <[email protected]>

* add test

Signed-off-by: HunDunDM <[email protected]>

* add comment

Signed-off-by: HunDunDM <[email protected]>

* fix import

Signed-off-by: HunDunDM <[email protected]>

* better select strategy

Signed-off-by: HunDunDM <[email protected]>

* tiny fix

Signed-off-by: HunDunDM <[email protected]>
ti-chi-bot added a commit that referenced this issue Feb 22, 2022
…ew peers (#4570) (#4577)

close #4565, ref #4570

Signed-off-by: HunDunDM <[email protected]>

Co-authored-by: HunDunDM <[email protected]>
Co-authored-by: JmPotato <[email protected]>
ti-chi-bot added a commit that referenced this issue Apr 14, 2022
…ew peers (#4570) (#4580)

close #4565, ref #4570

Signed-off-by: HunDunDM <[email protected]>

Co-authored-by: HunDunDM <[email protected]>
Co-authored-by: 混沌DM <[email protected]>
ti-chi-bot added a commit that referenced this issue Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants