Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on TLS feature on existing PD cluster #2996

Open
overvenus opened this issue Sep 21, 2020 · 3 comments
Open

Turn on TLS feature on existing PD cluster #2996

overvenus opened this issue Sep 21, 2020 · 3 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@overvenus
Copy link
Member

Bug Report

PD currently does not support enabling TLS feature on existing PD cluster, because it requires the "https" schema on client URL and peer URL that changes PD nodes address and it causes PD no leader.

[2020-09-21T05:10:43.408Z] [2020/09/21 13:09:35.425 +08:00] [INFO] [etcd.go:465] ["starting with peer TLS"] [tls-info="cert = tests/br_tls/certificates/server.pem, key = tests/br_tls/certificates/server-key.pem, trusted-ca = tests/br_tls/certificates/ca.pem, client-cert-auth = true, crl-file = "] [cipher-suites="[]"]
[2020-09-21T05:10:43.408Z] [2020/09/21 13:09:35.425 +08:00] [WARN] [etcd.go:502] ["scheme is HTTP while key and cert files are present; ignoring key and cert files"] [peer-url=http://127.0.0.1:2380]
[2020-09-21T05:10:43.408Z] [2020/09/21 13:09:35.425 +08:00] [WARN] [etcd.go:509] ["scheme is HTTP while --peer-client-cert-auth is enabled; ignoring client cert auth for this URL"] [peer-url=http://127.0.0.1:2380]
...
[2020-09-21T05:10:43.409Z] [2020/09/21 13:09:38.945 +08:00] [INFO] [history_buffer.go:147] ["start from history index"] [start-index=0]
[2020-09-21T05:10:43.409Z] [2020/09/21 13:09:38.946 +08:00] [WARN] [member.go:180] ["the pd leader has not changed, delete and campaign again"] [old-pd-leader="name:\"pd-br-test-go1130-nr3gr-1fvw2\" member_id:3474484975246189105 peer_urls:\"http://127.0.0.1:2380\" client_urls:\"http://127.0.0.1:2379\" "]
[2020-09-21T05:10:43.409Z] [2020/09/21 13:09:38.947 +08:00] [ERROR] [member.go:182] ["deleting pd leader key meets error"] [error="[PD:etcd:ErrEtcdTxn]etcd Txn failed"]
[2020-09-21T05:10:43.409Z] [2020/09/21 13:09:39.148 +08:00] [WARN] [member.go:180] ["the pd leader has not changed, delete and campaign again"] [old-pd-leader="name:\"pd-br-test-go1130-nr3gr-1fvw2\" member_id:3474484975246189105 peer_urls:\"http://127.0.0.1:2380\" client_urls:\"http://127.0.0.1:2379\" "]
...

What did you do?

Turn on TLS feature on existing PD cluster

What did you expect to see?

It works fine.

What did you see instead?

No leader.

What version of PD are you using (pd-server -V)?

master.

@overvenus overvenus added the type/bug The issue is confirmed as a bug. label Sep 21, 2020
overvenus added a commit to overvenus/br-1 that referenced this issue Sep 21, 2020
@nolouch nolouch added type/feature-request Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed type/bug The issue is confirmed as a bug. severity/moderate labels Jul 13, 2021
@nolouch
Copy link
Contributor

nolouch commented Jul 13, 2021

It should be a feature

@bufferflies
Copy link
Contributor

scale in single node to replace with pd-recover.

@rleungx
Copy link
Member

rleungx commented Dec 7, 2021

Related to pingcap/tiup#1598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants