address comment

Signed-off-by: lance6716 <[email protected]>
tikv · Dec 13, 2023 · c89be3a · c89be3a
1 parent 271f966
commit c89be3a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/client/http/client.go b/client/http/client.go
@@ -44,7 +44,6 @@ const (
 // Client is a PD (Placement Driver) HTTP client.
 type Client interface {
 	/* Meta-related interfaces */
-	GetClusterVersion(context.Context) (string, error)
 	GetRegionByID(context.Context, uint64) (*RegionInfo, error)
 	GetRegionByKey(context.Context, []byte) (*RegionInfo, error)
 	GetRegions(context.Context) (*RegionsInfo, error)
@@ -64,10 +63,11 @@ type Client interface {
 	/* Config-related interfaces */
 	GetScheduleConfig(context.Context) (map[string]interface{}, error)
 	SetScheduleConfig(context.Context, map[string]interface{}) error
+	GetClusterVersion(context.Context) (string, error)
 	/* Scheduler-related interfaces */
 	GetSchedulers(context.Context) ([]string, error)
 	CreateScheduler(ctx context.Context, name string, storeID uint64) error
-	PostSchedulerDelay(context.Context, string, int64) error
+	SetSchedulerDelay(context.Context, string, int64) error
 	/* Rule-related interfaces */
 	GetAllPlacementRuleBundles(context.Context) ([]*GroupBundle, error)
 	GetPlacementRuleBundleByGroup(context.Context, string) (*GroupBundle, error)
@@ -796,8 +796,8 @@ func (c *client) AccelerateScheduleInBatch(ctx context.Context, keyRanges []*Key
 		http.MethodPost, inputJSON, nil)
 }
 
-// PostSchedulerDelay changes the delay of given scheduler.
-func (c *client) PostSchedulerDelay(ctx context.Context, scheduler string, delaySec int64) error {
+// SetSchedulerDelay sets the delay of given scheduler.
+func (c *client) SetSchedulerDelay(ctx context.Context, scheduler string, delaySec int64) error {
 	m := map[string]int64{
 		"delay": delaySec,
 	}
@@ -806,7 +806,7 @@ func (c *client) PostSchedulerDelay(ctx context.Context, scheduler string, delay
 		return errors.Trace(err)
 	}
 	return c.requestWithRetry(ctx,
-		"PostSchedulerDelay", SchedulerByName(scheduler),
+		"SetSchedulerDelay", SchedulerByName(scheduler),
 		http.MethodPost, inputJSON, nil)
 }
 

diff --git a/tests/integrations/client/http_client_test.go b/tests/integrations/client/http_client_test.go
@@ -403,9 +403,9 @@ func (suite *httpClientTestSuite) TestSchedulers() {
 	schedulers, err = suite.client.GetSchedulers(suite.ctx)
 	re.NoError(err)
 	re.Len(schedulers, 1)
-	err = suite.client.PostSchedulerDelay(suite.ctx, "evict-leader-scheduler", 100)
+	err = suite.client.SetSchedulerDelay(suite.ctx, "evict-leader-scheduler", 100)
 	re.NoError(err)
-	err = suite.client.PostSchedulerDelay(suite.ctx, "not-exist", 100)
+	err = suite.client.SetSchedulerDelay(suite.ctx, "not-exist", 100)
 	re.ErrorContains(err, "500 Internal Server Error") // TODO: should return friendly error message
 }