add test

Signed-off-by: lhy1024 <[email protected]>
tikv · Aug 3, 2022 · bd70bf4 · bd70bf4
1 parent 6239cfc
commit bd70bf4
Showing 1 changed file with 38 additions and 10 deletions.
diff --git a/server/schedulers/hot_region_test.go b/server/schedulers/hot_region_test.go
@@ -1302,7 +1302,7 @@ func TestSkipUniformStore(t *testing.T) {
 	tc.AddRegionStore(4, 20)
 	tc.AddRegionStore(5, 20)
 
-	// Case 1 two dim are both enough uniform
+	// Case1: two dim are both enough uniform
 
 	tc.UpdateStorageReadStats(1, 10.05*units.MB*statistics.StoreHeartBeatReportInterval, 10.05*units.MB*statistics.StoreHeartBeatReportInterval)
 	tc.UpdateStorageReadStats(2, 9.45*units.MB*statistics.StoreHeartBeatReportInterval, 9.45*units.MB*statistics.StoreHeartBeatReportInterval)
@@ -1311,34 +1311,62 @@ func TestSkipUniformStore(t *testing.T) {
 		{1, []uint64{1, 2, 3}, 0.05 * units.MB, 0.05 * units.MB, 0},
 	})
 
-	stddevThreshold = 0.0 // no uniform store filter
+	// when there is no uniform store filter, still schedule although the cluster is enough uniform
+	stddevThreshold = 0.0
 	ops, _ := hb.Schedule(tc, false)
 	re.Len(ops, 1)
 	testutil.CheckTransferLeader(re, ops[0], operator.OpHotRegion, 1, 2)
 	clearPendingInfluence(hb.(*hotScheduler))
 
-	stddevThreshold = 0.1 // with uniform store filter
+	// when there is uniform store filter, not schedule
+	stddevThreshold = 0.1
 	ops, _ = hb.Schedule(tc, false)
 	re.Len(ops, 0)
 	clearPendingInfluence(hb.(*hotScheduler))
 
-	// Case 2 the first dim is enough uniform, we should schedule the second dim
+	// Case2: the first dim is enough uniform, we should schedule the second dim
 
-	tc.UpdateStorageReadStats(1, 10.05*units.MB*statistics.StoreHeartBeatReportInterval, 10.05*units.MB*statistics.StoreHeartBeatReportInterval)
+	tc.UpdateStorageReadStats(1, 10.15*units.MB*statistics.StoreHeartBeatReportInterval, 10.05*units.MB*statistics.StoreHeartBeatReportInterval)
 	tc.UpdateStorageReadStats(2, 9.45*units.MB*statistics.StoreHeartBeatReportInterval, 9.85*units.MB*statistics.StoreHeartBeatReportInterval)
-	tc.UpdateStorageReadStats(3, 9.55*units.MB*statistics.StoreHeartBeatReportInterval, 12.0*units.MB*statistics.StoreHeartBeatReportInterval)
+	tc.UpdateStorageReadStats(3, 9.85*units.MB*statistics.StoreHeartBeatReportInterval, 16.0*units.MB*statistics.StoreHeartBeatReportInterval)
 	addRegionInfo(tc, statistics.Read, []testRegionInfo{
-		{2, []uint64{1, 2, 3}, 0.05 * units.MB, 0.05 * units.MB, 0},
-		{3, []uint64{3, 2, 1}, 0.0 * units.MB, 2 * units.MB, 0},
+		{1, []uint64{1, 2, 3}, 0.05 * units.MB, 0.05 * units.MB, 0},
+		{2, []uint64{3, 2, 1}, 0.05 * units.MB, 2 * units.MB, 0},
 	})
 
-	stddevThreshold = 0.0 // no uniform store filter
+	// when there is no uniform store filter, still schedule although the first dim is enough uniform
+	stddevThreshold = 0.0
 	ops, _ = hb.Schedule(tc, false)
 	re.Len(ops, 1)
 	testutil.CheckTransferLeader(re, ops[0], operator.OpHotRegion, 1, 2)
 	clearPendingInfluence(hb.(*hotScheduler))
 
-	stddevThreshold = 0.1 // with uniform store filter
+	// when there is uniform store filter, schedule the second dim, which is no uniform
+	stddevThreshold = 0.1
+	ops, _ = hb.Schedule(tc, false)
+	re.Len(ops, 1)
+	testutil.CheckTransferLeader(re, ops[0], operator.OpHotRegion, 3, 2)
+	clearPendingInfluence(hb.(*hotScheduler))
+
+	// Case3: the second dim is enough uniform, we should schedule the first dim, although its rank is higher than the second dim
+
+	tc.UpdateStorageReadStats(1, 10.05*units.MB*statistics.StoreHeartBeatReportInterval, 10.05*units.MB*statistics.StoreHeartBeatReportInterval)
+	tc.UpdateStorageReadStats(2, 9.85*units.MB*statistics.StoreHeartBeatReportInterval, 9.45*units.MB*statistics.StoreHeartBeatReportInterval)
+	tc.UpdateStorageReadStats(3, 16*units.MB*statistics.StoreHeartBeatReportInterval, 9.85*units.MB*statistics.StoreHeartBeatReportInterval)
+	addRegionInfo(tc, statistics.Read, []testRegionInfo{
+		{1, []uint64{1, 2, 3}, 0.05 * units.MB, 0.05 * units.MB, 0},
+		{2, []uint64{3, 2, 1}, 2 * units.MB, 0.05 * units.MB, 0},
+	})
+
+	// when there is no uniform store filter, still schedule although the second dim is enough uniform
+	stddevThreshold = 0.0
+	ops, _ = hb.Schedule(tc, false)
+	re.Len(ops, 1)
+	testutil.CheckTransferLeader(re, ops[0], operator.OpHotRegion, 1, 2)
+	clearPendingInfluence(hb.(*hotScheduler))
+
+	// when there is uniform store filter, schedule the first dim, which is no uniform
+	stddevThreshold = 0.1
 	ops, _ = hb.Schedule(tc, false)
 	re.Len(ops, 1)
 	testutil.CheckTransferLeader(re, ops[0], operator.OpHotRegion, 3, 2)