Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[to #222] Change docs for TiUP #223

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Sep 13, 2022

Signed-off-by: pingyu [email protected]

What problem does this PR solve?

Issue Number: close #222

Problem Description: docs: Change TiUP related docs

What is changed and how does it work?

Change TiUP related docs & configuration templates.
Note that in TiUP, TiKV-CDC is using section kvcdc & kvcdc_servers.
Refer to pingcap/tiup#2022.

Code changes

  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • No code

Side effects

  • No side effects

Related changes

  • No related changes

Signed-off-by: pingyu <[email protected]>
@pingyu
Copy link
Collaborator Author

pingyu commented Sep 13, 2022

cc @zeminzhou @haojinming
PTAL, thanks~

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #223 (40c8cc9) into main (b0f96b0) will increase coverage by 0.1434%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main       #223        +/-   ##
================================================
+ Coverage   54.3692%   54.5127%   +0.1434%     
================================================
  Files           236        236                
  Lines         20278      20298        +20     
================================================
+ Hits          11025      11065        +40     
+ Misses         8376       8358        -18     
+ Partials        877        875         -2     
Flag Coverage Δ
cdc 61.5084% <ø> (+0.2005%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdc/cdc/sink/buffer_sink.go 80.0000% <0.0000%> (-1.8182%) ⬇️
cdc/cdc/sorter/unified/unified_sorter.go 91.6666% <0.0000%> (-0.6945%) ⬇️
cdc/cdc/sink/metrics.go 0.0000% <0.0000%> (ø)
cdc/cdc/sink/tikv.go 81.7796% <0.0000%> (+1.0621%) ⬆️
cdc/cdc/sorter/unified/merger.go 68.9320% <0.0000%> (+1.2944%) ⬆️
cdc/cdc/sorter/unified/heap_sorter.go 85.7142% <0.0000%> (+1.5306%) ⬆️
cdc/cdc/kv/client.go 85.7348% <0.0000%> (+1.5850%) ⬆️
cdc/pkg/util/key.go 71.4285% <0.0000%> (+1.7316%) ⬆️
cdc/cdc/sink/statistics.go 52.8571% <0.0000%> (+2.1108%) ⬆️
cdc/pkg/retry/retry_with_opt.go 95.4545% <0.0000%> (+4.5454%) ⬆️
... and 1 more

Copy link
Contributor

@haojinming haojinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Contributor

@zeminzhou zeminzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@pingyu pingyu merged commit 088ea7b into tikv:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Change TiUP related docs
3 participants