min-safe-ts: fix MinSafeTS might be set to MaxUint64 permanently #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: husharp <[email protected]>
nolouch
approved these changes
Oct 13, 2023
|
@JmPotato friendly ping :) |
JmPotato
reviewed
Nov 14, 2023
Signed-off-by: husharp <[email protected]>
done. |
|
@JmPotato friendly ping :) |
JmPotato
approved these changes
Nov 20, 2023
HuSharp
force-pushed
the
fix_cluster_init_zero_6.5
branch
2 times, most recently
from
16c4ce4 to
7bf04ba
Compare
Signed-off-by: husharp <[email protected]>
HuSharp
force-pushed
the
fix_cluster_init_zero_6.5
branch
from
7bf04ba to
2930514
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #991
cherry-pick #994
The core question is the getter
PD APIto not executego func which for KV request, resulting in not updatingsafeTSMap.updateMinSafeTSrelies onsafeTSMapwhich makes sense(because actually, we can callupdateMinSafeTStokvReuqestUpdater[to indicate func base]).minsafeTSto make sure when API fails we can fall back to the original way which is by kv request.updateMinSafeTSwill returnmaxUnit64when the first kv request returns 0 and then althoughPD APIreturns correctly[maybe kv is not initialized], TS can not changemaxUnit64.maxUnit64as 0 which means there is an initial state.