use leader read when tryFollower
is fallback from accessKnownLeader
#952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we made some changes to the selector states, the
tryFollower
is not only used as a fallback state ofaccessKnownLeader
, this PR keeps the compatibility oftryFollower
's requests.Before the changes we made:
accessKnownLeader
->tryFollower
-> switch leader when success, and the flagKVContext.ReplicaRead
is always false here.Now there is another path lead to
tryFollower
state:accessFollower
->tryFollower
, in this case,KVContext.ReplicaRead
is set to true intryFollower
state.To make the behavior compatible with earlier versions, we need to set a flag for the
accessKnownLeader
->tryFollower
path, and that'sfromKnownLeader
. It's renamed fromfromOnNotLeader
for better semantic.cc @crazycs520