-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support adding ExecDetailsV2
to tracing
#559
Conversation
Signed-off-by: zyguan <[email protected]>
return | ||
} | ||
|
||
spanRPC := spanInfo{name: "tikv.RPC", dur: td.TotalRpcWallTimeNs} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the TimeDetail
related information could be put together?
internal/client/client.go
Outdated
return buf.String() | ||
} | ||
|
||
func traceExecDetails(parent opentracing.Span, start time.Time, resp *tikvrpc.Response) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add a simple unit test to cover the converting process.
Signed-off-by: zyguan <[email protected]>
Signed-off-by: zyguan <[email protected]>
Signed-off-by: zyguan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest lgtm
please fix the lint warning. |
Signed-off-by: zyguan <[email protected]>
Signed-off-by: zyguan [email protected]
In order to show
ExecDetailsV2
in the trace statement, we have to convert the struct to spans of opentracing. This PR add the ability to do it.Here is an example.